servlet: Register response trailers before stream writes - #13029
Open
NianJiuZst wants to merge 1 commit into
Open
servlet: Register response trailers before stream writes#13029NianJiuZst wants to merge 1 commit into
NianJiuZst wants to merge 1 commit into
Conversation
Register the trailer supplier while creating the servlet stream, before a peer reset can cause the container to commit the response. This removes the race where Jetty throws IllegalStateException from writeHeaders after receiving RST_STREAM. Fixes grpc#12777
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeHeaders(), after a client RST_STREAM may already have caused Jetty to commit the responseThis removes the race where
HttpServletResponse.setTrailerFields()throwsIllegalStateException: Committed.Testing
./gradlew :grpc-servlet:jettyTest -PskipCodegen=true -PskipAndroid=true(80 tests, 19 skipped)./gradlew :grpc-servlet:tomcat9Test -PskipCodegen=true -PskipAndroid=true(78 tests, 29 skipped)./gradlew :grpc-servlet:undertowTest -PskipCodegen=true -PskipAndroid=true(78 tests, 23 skipped)./gradlew :grpc-servlet:checkstyleMain -PskipCodegen=true -PskipAndroid=trueFixes #12777