binder: Inbound must deliver even if the suffix arrives out of order - #13032
Open
jdcormie wants to merge 3 commits into
Open
binder: Inbound must deliver even if the suffix arrives out of order#13032jdcormie wants to merge 3 commits into
jdcormie wants to merge 3 commits into
Conversation
…getDelegate() Permits fake/mock implementations in tests that aren't actually backed by an IBinder at all. TAG=agy CONV=a7051e19-0fc1-42a4-8b24-5c2e3373aa0c
…gher layer It's hard to write a true unit test for Inbound because of its many concrete dependencies. However, today it has *no* unit tests, so we can't safely refactor it. To get out of this fix, we introduce ClientInboundTest and ServerInboundTest that target Inbound's logic by way of the Stream and BinderTransport. TAG=agy CONV=a7051e19-0fc1-42a4-8b24-5c2e3373aa0c
…ns initial queued slot TAG=agy CONV=a7051e19-0fc1-42a4-8b24-5c2e3373aa0c
jdcormie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression testing this bug fix required building unit tests for Inbound (it currently has none). We'll rely on these tests for other, bigger, upcoming changes like #12747 and #9010.
Will not squash please review each commit individually.