Repository navigation
binder: Avoid force-terminating BinderTransport on stale unregisterCall task - #13138
Merged
Merged
Conversation
…ll task When an ongoing call finishes and `unregisterCall()` observes `ongoingCalls.isEmpty()`, it schedules a task on `scheduledExecutorService` to finish transport shutdown if the transport is in `TransportState.SHUTDOWN`. However, `unregisterCall()` runs without holding `synchronized (this)` and may have scheduled this task while the transport is still in `TransportState.READY`. If a new stream is created before the transport enters `TransportState.SHUTDOWN`, the previously scheduled task can execute after `shutdown()` and call `shutdownInternal(shutdownStatus, true)`, force-terminating the newly started call with `UNAVAILABLE: Channel shutdown invoked`. Pass `forceTerminate = false` to `shutdownInternal()` so it re-checks `ongoingCalls.isEmpty()` while holding `synchronized (this)`.
ejona86
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an ongoing call finishes and
unregisterCall()observesongoingCalls.isEmpty(), it schedules a task onscheduledExecutorServiceto finish transport shutdown if the transport is inTransportState.SHUTDOWN. However,unregisterCall()runs without holdingsynchronized (this)and may have scheduled this task while the transport is still inTransportState.READY. If a new stream is created before the transport entersTransportState.SHUTDOWN, the previously scheduled task can execute aftershutdown()and callshutdownInternal(shutdownStatus, true), force-terminating the newly started call withUNAVAILABLE: Channel shutdown invoked.Pass
forceTerminate = falsetoshutdownInternal()so it re-checksongoingCalls.isEmpty()while holdingsynchronized (this).