Skip to content

feat: Enhance Discord bot user mapping and PR merge notifications #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lauriechammah merged 1 commit into from
Oct 28, 2026
+14 −1
Merged

feat: Enhance Discord bot user mapping and PR merge notifications #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/discord-bot/config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,19 @@ function loadUserMap() {
const map = {}
for (const [login, id] of Object.entries(raw)) {
if (login.startsWith('_')) continue // comment keys
map[login.toLowerCase()] = String(id)

// Discord rejects the whole message (400 on allowed_mentions) if a single id is
// not a snowflake, so one bad entry would silence the bot for everyone. Accept a
// pasted "<@123>" mention, and skip anything else that is not a bare id.
const snowflake = String(id).match(/^<?@?!?(\d{17,20})>?$/)?.[1]
if (typeof id === 'number' || !snowflake) {
console.warn(
`::warning::DISCORD_USER_MAP entry for "${login}" is not a Discord user id ` +
'(must be a quoted string of 17-20 digits, e.g. "123456789012345678"); skipped.',
)
continue
}
map[login.toLowerCase()] = snowflake
}
return map
}
Expand Down
1 change: 1 addition & 0 deletions .github/discord-bot/handlers/pull_request.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ async function onClosed(payload) {
const closes = closesIssues(pr)

await sendDiscord({
review: true,
content: `${mention(author)} — your PR #${pr.number} was merged into \`${pr.base?.ref}\` by ${mention(merger)}. 🎉`,
pingLogins: [...new Set([author, merger].filter(Boolean))],
embed: prEmbed(pr, repository, COLORS.merged, [
Expand Down
Loading