feat: SEAM 5 — the calibrate→pin→re-optimize verb chain (#681) - #695
Merged
Conversation
…g-entity pin, staged human-gated re-bank)
…est (additive note fields)
…verb, staged + completed) + structural promotion invariant
The e2e failed on the director's first run: the generated solve_B passed load_traj's raw NamedTrajectory straight to SmoothPulseProblem — the constructor wants a trajectory-with-pulse. The correct idiom re-wraps: warm = load_traj(seed); qtraj = UnitaryTrajectory(sys, ZeroOrderPulse(warm), op). Verified end-to-end green (the full calibrate -> pin -> warm-started re-solve -> provenanced re-bank -> executed_on_mock chain, real solves both legs). Also: the temp-dir cleanup now respects AMICO_DEBUG_KEEP_DIR (the env guard that made this diagnosis possible without a rerun).
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #681. Part of #679 (the codesign PRD). The chain as ONE recorded verb path over existing seams: STAGE amicode_calib_chain{leg: mock} — calibrate (the SEAM 1 rehearsal artifact read through the same dishonest-artifact-refusing reader; the hardware leg is structurally refused, names the five human gates, records nothing — the record type has only a mock variant), pin (the formulation calibration_pin constraint + solve.pinned_globals, additive, idempotent), re-optimize (the warm-start seed; the re-solve itself is the established bash launch), re-bank (the tool STAGES the exact ingest command with the chain fingerprint — calibration-ref, pin, warm-start — and performs no catalog write; promotion stays human-gated, the amico catalog ingest gains the additive provenance flags). COMPLETE amicode_calib_chain verifies the fingerprint against the promoted metadata and lands the countable executed_on_mock event. Director gates: fast suite 1847 passed + the 3 documented pre-existing env failures; typecheck clean; THE E2E EXECUTION RECORD — the chain ran end-to-end on mock through real solves by the director (one honest fix en route: the generated warm-start script re-wraps the loaded traj through ZeroOrderPulse; the e2e is green). Overlay untouched. Part of #679.