Conversation
Replace the hardcoded Map2CheckVersion #define in map2check.cpp with a header generated by CMake configure_file (map2check_version.hpp.in). The string follows v<version>-Songbirds:<UTC date> (date -u +%Y-%m-%d): - default: PROJECT_VERSION from the root CMakeLists (local/CI builds) - release: overridden with -DMAP2CHECK_VERSION=<semver> Since the version only exists after semantic-release analyzes the commits, the Docker build moves from a workflow step into the prepare phase: .releaserc.json now calls scripts/prepare-release.sh, which builds inside map2check-dev with the computed version and then invokes scripts/package-release.sh. Side benefit: pushes with no release-worthy commits skip the ~40 min build entirely. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded Map2CheckVersion #define in map2check.cpp with a header generated by CMake configure_file (map2check_version.hpp.in). The string follows v-Songbirds: (date -u +%Y-%m-%d):
Since the version only exists after semantic-release analyzes the commits, the Docker build moves from a workflow step into the prepare phase: .releaserc.json now calls scripts/prepare-release.sh, which builds inside map2check-dev with the computed version and then invokes scripts/package-release.sh. Side benefit: pushes with no release-worthy commits skip the ~40 min build entirely.
Description
Please include a summary of the your pull request. Please also include relevant motivation and context. List any dependencies that are required for this change.
Your checklist for this pull request
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Thank you!