add SWVO to PyHC - #390
add SWVO to PyHC#390
Conversation
|
Thanks for the submission, @sahiljhawar! Looks like a great project. Just wanted to let you know I've seen this, but it might take me a week or so to get to it. |
|
Hi again @sahiljhawar, sorry for the delay but I finally got around to reviewing this. First off, this is a great package that will be a great addition to PyHC! We’d love to have you, there are just a couple things to discuss first.
Please review the new report and update your grades here if you agree? The main reasons for the changes are: Software Maturity is actually “good” because the package meets all “musts” in our standards (“shoulds” are not strict requirements), Documentation is “partially met” mostly because of missing docstrings, and PHEP 3 is demoted to “partially met” because your requirements unfortunately violate our PHEP 3 support timeline.
The good news is fixing the PHEP 3 issues would also fix PyHC Environment compatibility, and tests I ran locally seemed to indicate your package still works with the different minimum bounds we’d require. We publish two reusable GitHub Actions in pyhc-actions that should simplify this for you—I’d recommend adding them to your CI if you’re game: - uses: heliophysicsPy/pyhc-actions/phep3-compliance@v1
- uses: heliophysicsPy/pyhc-actions/pyhc-env-compat@v1I’ll note that none of this is a hard requirement for merging; if you'd rather not make these changes we can still accept SWVO. But it would mean leaving SWVO out of the PyHC Environment which would obviously be a shame. I'd rather get compatibility sorted first if you're up for it! (Once a release with the relaxed pins is on PyPI, I’d merge this—with PHEP 3 marked Good.) |
|
Hi @sapols, thanks for the detailed review. Here's where things stand after working through your feedback: Done
Under consideration
Updated self-assessed grades
|
|
@sapols We now have new version SWVO v1.2.8 with the required changes |
SWVO meets every "must" in the PyHC software maturity standard, so the grade is Good; the remaining gaps are "shoulds", which are not strict requirements.
|
Fantastic work, @sahiljhawar. Thanks for the quick turnaround! SWVO is accepted into PyHC 🎉 I updated this PR to reflect that SWVO now earns Good in all six categories. Relaxing those pins also sorted out PyHC Environment compatibility, so SWVO ships in the environment as of today's build. I'm merging this now. SWVO now appears in:
One more thing, if you're up for it, we'd love for you to present SWVO at an upcoming PyHC telecon. We think our members would be interested to hear about it. If this sounds good to you, our PI Julie will get in touch to schedule that. Welcome to PyHC! 👋 |
|
@sapols Amazing, thank you! |
Add SWVO to the PyHC project list
Adds SWVO (https://github.com/GFZ/SWVO) to _data/projects.yml.
SWVO is a Python package for downloading and reading space-weather data and geomagnetic indices (Kp, Dst, Hp, F10.7, SuperMAG electrojet/substorm indices, solar wind parameters from ACE/DSCOVR/OMNI/ENLIL, and plasmasphere density predictions).
Self-assessed grades:
Here's the evaluation doc: SWVO_PyHC_Evaluation.md
Contact: Sahil Jhawar (jhawar@gfz.de), Bernhard Haas (bhaas@gfz.de)