Skip to content

PHEP 2 revision to remove "accepted" status - #57

Merged
sapols merged 1 commit into
heliophysicsPy:mainfrom
jtniehof:phep2_v2_clarifications
Nov 6, 2026
Merged

sapols merged 1 commit into
heliophysicsPy:mainfrom
jtniehof:phep2_v2_clarifications

Conversation

@jtniehof

@jtniehof jtniehof commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

This is the PHEP 2 sibling to #56 that just changes the same line in the template.

The new Zenodo record is ready to go and I optimistically put in today as the release date, but of course that can be revised.

 * Matches phep 1 update

Amended by the PHEP editor before merge: link "approve the draft PHEP" to the Submitting a PHEP section of PHEP 1.
@sapols

sapols commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Thanks again @jtniehof! One fix before merging: the "approve the draft PHEP" link points to #submitting-a-phep, which is a section of PHEP 1 but not PHEP 2. I'd like to point it at PHEP 1's section with an absolute URL (so the link isn't broken and will also work in the PDF):

-[approve the draft PHEP](#submitting-a-phep)
+[approve the draft PHEP](https://github.com/heliophysicsPy/standards/blob/main/pheps/phep-0001.md#submitting-a-phep)

To keep it a single commit, I'll amend yours like we did on #56, adding this line to the commit message:

Amended by the PHEP editor before merge: link "approve the draft PHEP" to the Submitting a PHEP section of PHEP 1.

Look good? If so, I'll merge and release today so the 06-Nov-2026 dates hold.

@jtniehof

jtniehof commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Oooh, good catch. (I checked other internal anchors and missed that).

That's one option. The other would be to just link the DOI for PHEP 1. That has the advantage of a permalink, but the disadvantage of not being able to do the internal link. I'll leave the choice to your discretion.

@sapols
sapols force-pushed the phep2_v2_clarifications branch from 5953528 to 27f89da Compare November 6, 2026 23:18
@sapols
sapols merged commit 2242a5d into heliophysicsPy:main Nov 6, 2026
1 check passed
sapols added a commit that referenced this pull request Nov 6, 2026
Merge pull request #57 from jtniehof/phep2_v2_clarifications
@sapols

sapols commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

@jtniehof Merged and released! PHEP-2 Release 2 is up, so the Zenodo upload is all yours. I went with the main link to PHEP 1's Submitting a PHEP section, since it's not expected to move or change any time soon and I wanted the internal link to land.

That's the good news. Slight bad news is that after merging, I noticed the two Revisions entries were running together as one paragraph when rendered (because CommonMark needed a blank line between them that was missing—it's amazing how much can go wrong here for such a simple change).

To keep revision 2 a single commit, I folded the blank line into the amended commit and replaced the merge on main, so the "merged commit 2242a5d" above is now ef1a43e. Apart from that blank line, the content is identical. If you pulled main in the last hour, your local copy will be out of sync; git fetch then git reset --hard origin/main will fix it.

Per RELEASE.md:

  • Files: phep-0002.pdf from the release, plus the Markdown source at the tagged commit
  • Publication date: 06-Nov-2026 · Version: 2 · Dates: Created 06-Dec-2023, Accepted 13-Nov-2024, Updated 06-Nov-2026
  • Related works: "Is derived from" the release URL and the tagged-source URL above; "Is new version of" 10.5281/zenodo.14187913. On the revision 1 record, add "Is previous version of" 10.5281/zenodo.23964987.

The website's PHEP table update is ready in this draft PR; I'll mark it ready and merge it once the DOI is live.

@jtniehof

jtniehof commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

New record published in https://zenodo.org/records/23964987

@sapols

sapols commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Thank you so much Jon <3 One small thing: the v2 record’s Version field is empty (v1 has “1”). Could you set it to 2? It’s just metadata, so it’s editable any time.

@jtniehof
jtniehof deleted the phep2_v2_clarifications branch November 11, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants