Repository navigation
Fable review fixes for the becf853def sync - #258
Merged
Merged
Conversation
The helper entry statically imported the whole server runtime, so every office document extraction child evaluated the full bundle (about 5 s under amd64 emulation, near the 15 s timeout with a 192 MB heap). Move the stdio runtime to helper.ts and import each branch lazily, as upstream's bin.ts does; the child now takes about 1.8 s. Also drop bin.test.ts's unused ProviderInstanceId. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An older fork edit dropped upstream's activeDraftThread fallback without a seam, so the file picker and content search had no project on draft routes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Thread details rendered the workspace row twice (a line upstream removed). - The title menu waited the desktop delay in the browser; open it at once as upstream's web build does. - Thread notifications uses upstream's searchable row again. - Restore upstream's Jujutsu VCS icon mapping. - Merge request and T3 Coder wording for the MR page ghosts and error, the sent-by attribution, and the keybindings browser notice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Delete fork-only modules nothing imports (claudeCompaction, composerSelectionHold, composerImageThumbnail) and a test for an uncarried script; drop the shared ./dateTime export and a stale knip entry for moved files, the unused desktop download URL, and client-runtime vcs.ts's duplicate preparePullRequestThread. Mark compatibility.ts's self-update cut and say T3 Coder; give the diff contents cache limits their reasons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pass autoCodeSplitting to the router plugin as upstream does, and adopt upstream's single-copy catalog pins for Tailwind and lightningcss (4.3.3 and 1.33.0), with enhanced-resolve pinned to upstream's resolved version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings paths in the user docs and README follow pingdotgg#25651's pages; coder-only.md names LabsSettingsPanel, the Diffs MR link row, the lazy helper entry, the build and tooling differences, and the inline token formatter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the Fable review of the becf853 sync (#256, #257). The review found no regressions in the sync merges themselves. These are the real issues it found, mostly older drift the sync carried forward.
Behavior
DocumentText's 15 s timeout with a 192 MB heap. The stdio runtime now lives inhelper.ts, and both branches import lazily, as upstream'sbin.tsdoes. The child now takes about 1.8 s (a barenodestart is 0.4 s).useActiveProjectTargetgets upstream's draft fallback back, so the ⌘P file picker and ⇧⌘F search work on draft routes.Wording and dead code
claudeCompaction,composerSelectionHoldandcomposerImageThumbnail, plus a test for an uncarried script../dateTimeexport, a knip entry for a moved file, the desktop download URL, and a duplicatepreparePullRequestThread.Upstream parity
autoCodeSplitting) is back on.enhanced-resolvematches upstream's resolved version.Docs
coder-only.mdcorrections:LabsSettingsPanel, the MR link row on Diffs, the lazy helper entry, the build and tooling differences, and the inline token formatter.Left as is (already documented)
"request"sidebar status. Nothing can create a share, and removing it would add seams in four files.ws/@types/wsstay pinned by the gateway; this is now noted in Build tooling.Verification
pnpm knip:check,pnpm build, andvp fmt --checkon the changed files.pnpm test:coder: server 3,188 tests. The knownlocalApi.test.tsflake (Tests that flake under full-suite load #236) failed once in the full run; the web suite then passed on rerun (3,884 tests), as did the knip test.node:24amd64 container.🤖 Generated with Claude Code