Skip to content

Fable review fixes for the becf853def sync - #258

Merged
henrychu04 merged 6 commits into
coder-onlyfrom
t3code/fable-review-fixes-becf853def
Oct 27, 2026
Merged

henrychu04 merged 6 commits into
coder-onlyfrom
t3code/fable-review-fixes-becf853def

Conversation

@henrychu04

Copy link
Copy Markdown
Owner

Fixes from the Fable review of the becf853 sync (#256, #257). The review found no regressions in the sync merges themselves. These are the real issues it found, mostly older drift the sync carried forward.

Behavior

  • Document-text child loads only its worker. The helper entry statically imported the whole server runtime, so each office-document extraction child evaluated the full bundle: about 5 s under amd64 emulation, close to DocumentText's 15 s timeout with a 192 MB heap. The stdio runtime now lives in helper.ts, and both branches import lazily, as upstream's bin.ts does. The child now takes about 1.8 s (a bare node start is 0.4 s).
  • Draft threads have a project target again. useActiveProjectTarget gets upstream's draft fallback back, so the ⌘P file picker and ⇧⌘F search work on draft routes.
  • Thread details no longer shows the workspace row twice.
  • Thread title menu opens immediately in the browser, as upstream's web build does.
  • Thread notifications settings row is upstream's searchable row again.

Wording and dead code

  • MR and T3 Coder wording:
    • the merge requests page loading ghosts and its error;
    • "Sent by T3 Coder";
    • the keybindings browser notice;
    • the protocol-compatibility message.
  • Deleted modules no one imports: claudeCompaction, composerSelectionHold and composerImageThumbnail, plus a test for an uncarried script.
  • Removed stale config: the shared ./dateTime export, a knip entry for a moved file, the desktop download URL, and a duplicate preparePullRequestThread.
  • Restored upstream's Jujutsu icon mapping.

Upstream parity

  • Route code splitting (autoCodeSplitting) is back on.
  • Upstream's single-copy pins for Tailwind and lightningcss (4.3.3 and 1.33.0); enhanced-resolve matches upstream's resolved version.

Docs

  • Settings paths in the user docs and README follow the regrouped pages.
  • coder-only.md corrections: LabsSettingsPanel, the MR link row on Diffs, the lazy helper entry, the build and tooling differences, and the inline token formatter.

Left as is (already documented)

  • The dormant guest "request" sidebar status. Nothing can create a share, and removing it would add seams in four files.
  • ws/@types/ws stay pinned by the gateway; this is now noted in Build tooling.

Verification

  • All typechecks pass, as do pnpm knip:check, pnpm build, and vp fmt --check on the changed files.
  • pnpm test:coder: server 3,188 tests. The known localApi.test.ts flake (Tests that flake under full-suite load #236) failed once in the full run; the web suite then passed on rerun (3,884 tests), as did the knip test.
  • Mock smoke tests (gateway with helper, and signed assets) pass.
  • The rebuilt Linux helper bundle extracts notebook text in about 1.8 s and boots normally in a node:24 amd64 container.

🤖 Generated with Claude Code

henrychu04 and others added 6 commits October 27, 2026 08:20
The helper entry statically imported the whole server runtime, so every office
document extraction child evaluated the full bundle (about 5 s under amd64
emulation, near the 15 s timeout with a 192 MB heap). Move the stdio runtime to
helper.ts and import each branch lazily, as upstream's bin.ts does; the child
now takes about 1.8 s. Also drop bin.test.ts's unused ProviderInstanceId.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An older fork edit dropped upstream's activeDraftThread fallback without a
seam, so the file picker and content search had no project on draft routes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Thread details rendered the workspace row twice (a line upstream removed).
- The title menu waited the desktop delay in the browser; open it at once as
  upstream's web build does.
- Thread notifications uses upstream's searchable row again.
- Restore upstream's Jujutsu VCS icon mapping.
- Merge request and T3 Coder wording for the MR page ghosts and error, the
  sent-by attribution, and the keybindings browser notice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Delete fork-only modules nothing imports (claudeCompaction, composerSelectionHold,
composerImageThumbnail) and a test for an uncarried script; drop the shared
./dateTime export and a stale knip entry for moved files, the unused desktop
download URL, and client-runtime vcs.ts's duplicate preparePullRequestThread.
Mark compatibility.ts's self-update cut and say T3 Coder; give the diff contents
cache limits their reasons.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pass autoCodeSplitting to the router plugin as upstream does, and adopt
upstream's single-copy catalog pins for Tailwind and lightningcss (4.3.3 and
1.33.0), with enhanced-resolve pinned to upstream's resolved version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings paths in the user docs and README follow pingdotgg#25651's pages; coder-only.md
names LabsSettingsPanel, the Diffs MR link row, the lazy helper entry, the build
and tooling differences, and the inline token formatter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@henrychu04
henrychu04 merged commit 9486780 into coder-only Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant