Skip to content

Fix what the Fable review of the e9236274a3 sync found - #261

Merged
henrychu04 merged 1 commit into
coder-onlyfrom
t3code/fable-review-fixes-e9236274a3
Oct 27, 2026
Merged

henrychu04 merged 1 commit into
coder-onlyfrom
t3code/fable-review-fixes-e9236274a3

Conversation

@henrychu04

Copy link
Copy Markdown
Owner

Follow-ups from the Fable review of the e923627 sync (#259, #260). The review used three read-only area reviewers: server and bridge, client-runtime, and web plus gateway. None of them found a merge regression. This PR fixes the small drift they did report.

Changes

Not changed, by choice

  • Upstream-verbatim helpers used only by their tests: resolveAddProjectEntry and the ACP wizard helpers. Their files stay byte-identical to upstream, which keeps syncs small.
  • The inert silent-socket loop that comes with the gateway route's checkHost seam. Cutting it would make the supervisor delta much larger.
  • Pre-existing "T3 Code" strings in About, provider status, and keybinding text.

Verification

  • pnpm typecheck:web passes.
  • The CommandPalette browser and logic tests pass (35 tests).
  • pnpm test:web:coder: 3944 of 3945 tests pass. The one failure, localApi.test.ts, is the known load flake (Tests that flake under full-suite load #236) and passes when run alone.
  • pnpm knip:check, vp fmt --check, and node scripts/sync-resolve-deleted.mjs all pass.

🤖 Generated with Claude Code

- Drop the palette's dead "environments" view check: every Add project view
  now opens on ADD_PROJECT_ENTRY_GROUP.
- Record upstream's CI-only cuts (the agent context budget test and the
  built web boot check) in the seams doc, sync.md, and the resolve-deleted
  data.
- Seams doc: the uncarried supervisor test, the canvas tests without
  preview cases, the CommandPalette browser test's useCoder mock, a stale
  focus-test sentence, and the GitLab fixes checked against e923627.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@henrychu04
henrychu04 merged commit 116e4a2 into coder-only Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant