Repository navigation
Fix what the Fable review of the e9236274a3 sync found - #261
Merged
Merged
Conversation
- Drop the palette's dead "environments" view check: every Add project view now opens on ADD_PROJECT_ENTRY_GROUP. - Record upstream's CI-only cuts (the agent context budget test and the built web boot check) in the seams doc, sync.md, and the resolve-deleted data. - Seams doc: the uncarried supervisor test, the canvas tests without preview cases, the CommandPalette browser test's useCoder mock, a stale focus-test sentence, and the GitLab fixes checked against e923627. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the Fable review of the e923627 sync (#259, #260). The review used three read-only area reviewers: server and bridge, client-runtime, and web plus gateway. None of them found a merge regression. This PR fixes the small drift they did report.
Changes
isAddProjectEnvironmentViewno longer checks the"environments"group. After refactor(web): command palette state lives in a store, git and branch pickers drop timer and sync effects pingdotgg/t3code#25733, every Add project view opens onADD_PROJECT_ENTRY_GROUP, so that arm was dead.sync.md, andsync-resolve-deleted.mjs, so the next sync removes them automatically. The budget test measures MCP tool context, which the file bridge replaces.connection/supervisor.test.tsis not carried.CommandPalette.browser.test.tsx'suseCodermock.source-control-gitlabin this range.Not changed, by choice
resolveAddProjectEntryand the ACP wizard helpers. Their files stay byte-identical to upstream, which keeps syncs small.checkHostseam. Cutting it would make the supervisor delta much larger.Verification
pnpm typecheck:webpasses.pnpm test:web:coder: 3944 of 3945 tests pass. The one failure,localApi.test.ts, is the known load flake (Tests that flake under full-suite load #236) and passes when run alone.pnpm knip:check,vp fmt --check, andnode scripts/sync-resolve-deleted.mjsall pass.🤖 Generated with Claude Code