Repository navigation
Fix what the Fable review of the sync and the gateway hub found - #271
Merged
Merged
Conversation
Found by the Fable review of #268. A linked workspace that has not connected since the gateway started now answers orchestration_error (retryable) instead of capability_denied, so a delegated task re-followed after a restart waits for it rather than failing. Labs' switch being off in the target answers upstream PeerMcpClient's non-final orchestration_error. The gateway answers an undecodable outbox request at once instead of letting the caller time out, and editing a link rule's endpoints mints a new rule id, since the id is the origin the linkOrigin fence compares. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sync-resolve-deleted.mjs and sync.md list the triage, dev-servers and dev-replay paths the sync cut; the seams doc names threadContextsOutsideEnvironment, bumps the GitLab fixes' checked-against SHA to 67661cf, and states the hub's retry and Labs-off behaviour; Coder: markers mark the machine-chip and pingdotgg#26201 cuts and the dropped secret-request metric; docs/user/keyboard-focus.md (F6 navigation) is carried with merge-request wording and linked from Keyboard shortcuts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fable reviewed the e923627 → 67661cf sync (#262–#267) in three areas, plus the gateway-hub delegation work (#268–#270). It found no merge losses or lost seams in the sync. This PR fixes what it did find.
Linked workspaces (from the #268 review)
capability_denied("not linked").RemoteDelegationtreats that as final, so a re-followed task failed even though the rule existed and the work was still running. It's now a retryableorchestration_erroruntil that workspace connects. A call with no matching rule is still refused for good.PeerMcpClient's non-finalorchestration_error, so a running task resumes once the switch is back on. Before, it failed the task permanently.linkOriginfence compares, so a re-pointed rule could otherwise inherit another workspace's fenced work.Sync follow-ups
scripts/sync-resolve-deleted.mjsandsync.md§3 list the triage, dev-servers and dev-replay paths the sync cut, so the next sync auto-resolves them.threadContextsOutsideEnvironment(it saidstrandedThreadContexts, which doesn't exist);Coder:markers at the machine-chip and feat(web,mobile): the @ picker lists threads on linked machines pingdotgg/t3code#26201 cut sites and at the dropped secret-request metric.docs/user/keyboard-focus.md(F6 workspace navigation, carried in Merge upstream/main 3b2f958603 into coder-only (sync stage 3 of 4) #264) is carried with merge-request wording and linked from Keyboard shortcuts.Not changed
ClaudeSkills.test.tsfailing on macOS is upstream's (ClaudeSkills plugin-order test fails on macOS (/var symlink) #235).Verification:
pnpm knip:checkandvp fmt --checkpass.coderHub.test.tsandOrchestratorMcpService.test.tspass (44 tests). Gateway and coder-cli node tests pass (119). 37 web settings/composer/ChatView test files pass.orchestration_error, an unknown environment with no rule getscapability_denied, and an unreadable request is answered with its id at once.🤖 Generated with Claude Code