feat(robot): keep the IPv6 ExternalIP configured on a Robot node - #1340
Open
lukasmetzner wants to merge 1 commit into
Open
feat(robot): keep the IPv6 ExternalIP configured on a Robot node#1340lukasmetzner wants to merge 1 commit into
lukasmetzner wants to merge 1 commit into
Conversation
Robot reports the IPv6 subnet assigned to a server, but not the address the server uses within it, so we use the first address of the subnet. That address is wrong for servers that use another address out of their subnet, and unavailable for servers that have no subnet in Robot at all, e.g. when IPv6 is configured on upstream network equipment instead of per server. Keep the IPv6 ExternalIP that is already configured on the Node object if it is part of the subnet Robot reports, and fall back to the first address of the subnet otherwise. If Robot reports no subnet, the configured address is the only source and is kept as is. Closes #1338
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
+ Coverage 70.27% 70.38% +0.10%
==========================================
Files 29 29
Lines 2816 2826 +10
==========================================
+ Hits 1979 1989 +10
Misses 647 647
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robot reports the IPv6 subnet assigned to a server, but not the address
the server uses within it, so we use the first address of the subnet.
That address is wrong for servers that use another address out of their
subnet, and unavailable for servers that have no subnet in Robot at all,
e.g. when IPv6 is configured on upstream network equipment instead of per
server.
Keep the IPv6 ExternalIP that is already configured on the Node object if
it is part of the subnet Robot reports, and fall back to the first address
of the subnet otherwise. If Robot reports no subnet, the configured
address is the only source and is kept as is.
Closes #1338