Skip to content

fix(audits): avoid caption false positives#2319

Closed
miguel-heygen wants to merge 1 commit into
mainfrom
fix/cli-feedback-audit-false-positives
Closed

fix(audits): avoid caption false positives#2319
miguel-heygen wants to merge 1 commit into
mainfrom
fix/cli-feedback-audit-false-positives

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Summary

  • preserve lexical scopes while expanding computed GSAP loops so iteration-local DOM targets remain distinct
  • stop promoting text from hidden descendant captions to a visible parent during layout occlusion audits
  • add parser lint and browser-audit regression coverage for both reported false positives

Reproduction

Confirmed against HyperFrames 0.7.54 and 0.7.55:

  • loop-local getElementById("caption-card-" + i) targets were collapsed to the first selector and triggered overlapping_gsap_tweens
  • a visible caption container whose only text child had opacity 0 was reported as text_occluded

Verification

  • parsers: 27 files passed; 812 tests passed
  • lint: 13 files passed; 363 tests passed
  • CLI layout/check: 2 files passed; 78 tests passed
  • parser lint and CLI typechecks passed
  • both original source-level repro projects now return zero findings

@miguel-heygen

Copy link
Copy Markdown
Collaborator Author

Superseded by #2413, which consolidates this regression with the related lint/audit correctness fixes, preserves the unique coverage, and is green across all required CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant