Skip to content

fix(producer): pass variables to duration probe#2338

Closed
miguel-heygen wants to merge 1 commit into
mainfrom
fix/render-variable-duration
Closed

fix(producer): pass variables to duration probe#2338
miguel-heygen wants to merge 1 commit into
mainfrom
fix/render-variable-duration

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Summary

  • pass render variable overrides into the browser session used for duration discovery
  • keep duration derivation and frame capture on the same variable state
  • add regression coverage at the producer probe boundary

Reproduction

Confirmed on published 0.7.56: render --variables {"short":true} exposed the value during capture but duration discovery used the default state, producing 240 frames / 10s instead of 48 frames / 2s at 24fps.

Tests

  • bun test packages/producer/src/services/render/stages/probeStage.test.ts
  • bun run --cwd packages/producer typecheck
  • pre-commit lint/format/fallow/typecheck

@miguel-heygen

Copy link
Copy Markdown
Collaborator Author

Consolidated with the related duration and timing correctness fixes in #2405, which preserves this PR’s behavior and regression coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant