Skip to content

fix(lint): ignore proxy-label tween overlaps#2381

Closed
miguel-heygen wants to merge 2 commits into
mainfrom
fix/proxy-overlap-lint-1783992350
Closed

fix(lint): ignore proxy-label tween overlaps#2381
miguel-heygen wants to merge 2 commits into
mainfrom
fix/proxy-overlap-lint-1783992350

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Summary

  • stop treating parser role labels such as dwell/hold and proxy → … as stable target identities
  • avoid false overlapping_gsap_tweens findings for simultaneous drivers on distinct object proxies
  • retain overlap detection for resolved DOM targets

Reproduction

Confirmed on hyperframes@0.7.56: two distinct proxy objects, each tweening value from 0–2s with ease: "none", both collapse to the dwell/hold parser label and lint reports a phantom self-overlap.

Source feedback: https://heygen.slack.com/archives/C0BGC335AQY/p1783992350130129

Verification

  • bun test packages/lint/src/rules/gsap.test.ts (86 passed)
  • bun run --cwd packages/lint typecheck
  • bunx oxfmt --check packages/lint/src/rules/gsap.ts packages/lint/src/rules/gsap.test.ts
  • bunx oxlint packages/lint/src/rules/gsap.ts packages/lint/src/rules/gsap.test.ts
  • git diff --check

The repository-wide pre-commit typecheck was attempted but a fresh worktree lacks generated packages/core/src/generated/runtime-inline modules; fallow also evaluated unrelated baseline changes against origin/main. Targeted lint tests, package typecheck, formatting, and lint all pass.

Human review required; do not self-merge.

@miguel-heygen

Copy link
Copy Markdown
Collaborator Author

Superseded by #2413, which consolidates this regression with the related lint/audit correctness fixes, preserves the unique coverage, and is green across all required CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant