Repository navigation
feat(player): add customizable branding to the preview player - #7718
Open
robinebers wants to merge 2 commits into
Open
robinebers wants to merge 2 commits into
robinebers wants to merge 2 commits into
Conversation
A page that embeds <hyperframes-player> can now give it its own play, pause and volume icons and its own loading logo, by putting elements with a slot attribute inside the player. Anything the page leaves out keeps today's HyperFrames look. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
miguel-heygen
approved these changes
Nov 14, 2026
miguel-heygen
enabled auto-merge
November 14, 2026 05:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Teams that put the HyperFrames player inside their own product get the HyperFrames play button, volume icons and green HyperFrames logo on the loading screen, and there is no supported way to change them. The player looks like someone else's product sitting inside yours. The only workaround today is reaching into the player's internals, which can break with any release.
What changes
A page can now give the player its own artwork. You put an icon inside the
<hyperframes-player>tag and label which part it replaces: the play icon, the pause icon, the three volume icons (loud, quiet, muted) or the loading logo. The player shows it in place of its own.Before
The page supplies its own icons and logo, and the player ignores them.
After
The same page: the player shows the page's icons in the control bar and its logo on the loading screen.
Test plan
Checked in Chrome 157 against a build of
mainon the same pages:main.sandbox-origin="opaque".--hfp-color).controlsis turned off and on and after the player is moved in the page, and stay hidden whilecontrolsis off.bun run --cwd packages/player test(584 tests, 5 new), typecheck, oxlint, oxfmt, fallow, the comment checks andbun run verify:packed-manifestspass.How
<slot>in the player's shadow DOM, with today's SVG as the fallback:play-icon,pause-icon,volume-high-icon,volume-low-icon,volume-muted-iconandloading-mark. No new attributes, CSS variables, parts or styles.loading-markfallback, so a custom logo never gets them.mainpacks to 158,705 bytes, 11 under the old limit. This change adds about 380 bytes of code and 600 bytes of README (packed 159,691).Related work
No earlier issue or PR covers player icons or branding. #241 added the speed menu and the control bar's CSS theming, whose color these icons pick up.