parse_functions: find functions inside FROM-clause subqueries, joins and table-function arguments - #17
Open
asubbarao wants to merge 3 commits into
Open
parse_functions: find functions inside FROM-clause subqueries, joins and table-function arguments#17asubbarao wants to merge 3 commits into
asubbarao wants to merge 3 commits into
Conversation
asubbarao
requested review from
shefeek-jinnah
and removed request for
a team
September 24, 2026 21:22
Author
|
The red Windows job here is not from this change: |
extension-ci-tools <= v1.5.x defines TEST_PATH with baked-in quotes (TEST_PATH="/test/unittest"), so 'make test_release' invokes ./build/release/"/test/unittest", which fails with Error 127 on Windows (Git Bash) before the test binary ever runs. Fixed upstream in v2.0-cyanoptera via the RUN_TEST macro; override test_release_internal here until ci_tools can move past v1.5.x. Identical to the stock recipe on POSIX.
The extension-ci-tools workflow hardcodes vcvars64.bat under "C:\Program Files\Microsoft Visual Studio\2022\Enterprise", which no longer exists on current windows-latest runners. The call fails with "The system cannot find the path specified", CMake then silently falls back to a stray GCC 15.2.0, and the resulting unittest binary cannot be launched from Git Bash (Error 127, deterministic across the 2026-09-24 and 2026-10-04 runs). This was misdiagnosed earlier as a test-harness quoting bug; the invoked command line is byte-identical on the passing mingw job. Set SKIP_TESTS=1 for windows_amd64 (before the ci-tools include, which reads it at include time) until upstream fixes the VS path. Windows coverage is retained via windows_amd64_mingw, where the full suite (11 tests / 435 assertions) passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_function_namesandparse_functionsskip everything in the FROM clause: subqueries, both sides of a join, and table-function arguments, as well as scalar subqueries. The community build (parser_toolspinned at 6a94f2b) returns[]for the first query below.The traversal now descends into
from_table(join sides and conditions, subquery references, table-function arguments and subqueries) and intoSubqueryExpression, following the same table-reference patternparse_tablesuses.FROM (SELECT avg(n) …) s[][avg]FROM (SELECT upper(x) …) a JOIN (SELECT lower(y) …) b[][upper, lower]FROM range(abs(-5))[][abs]SELECT (SELECT sum(1)) WHERE x IN (SELECT length(z) …)[][sum, length]Verified against DuckDB v1.4.4 (this repo's pin): the four cases are added to both
parse_function_names.testandparse_functions.test. On the unpatched source both files fail ([] <> [avg], 2 of 11 test cases); with the patch all 11 test cases pass.🤖 Generated with Claude Code