Repository navigation
Close phase 0 and plan phase 1 - #3
Merged
Merged
Conversation
The roadmap records PR #2 and the three ways phase 0 changed later phases. plan.md now holds phase 1, the storage contract offline: ten tasks, seven acceptance criteria, and four defaults the brief left open (an embedder and a clock given to MemoryStore, a dataclass filter, and a src layout that is built but not yet published).
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| 5. `MemoryStore`: revisions and supersession, exact deduplication on normalized content, | ||
| whole-label namespace matching, `forget_after` hiding, cosine distance through the | ||
| embedder, and a buffered `writer` that returns the ids it flushed (section 3.3). | ||
| 6. The conformance suite: one test for each answered guarantee in `docs/guarantees.md` |
There was a problem hiding this comment.
nit: Name the driver-specific rows in docs/guarantees.md that task 6 defers to phase 2. (not blocking)
The row "Two processes write to the same table" is answered, measured (M3), and concerns the storage contract. The 409 retry with backoff exists only in HotdataStore. A test against MemoryStore cannot observe the 409 retry. AC4 requires a passing test for that row, so the first stop condition fires with certainty. The same applies to the sweeper half of the forget_after row. A one-line list of deferred rows here keeps AC4 satisfiable without a stop.
MemoryStore can match the engine's cosine distance but not its BM25 scoring, so phase 2 decides between an exact vector-only comparison and a looser one for fused search.
rohan-hotdata
requested review from
shefeek-jinnah
and removed request for
a team
October 5, 2026 16:06
17 tasks
Adds the fifth decision, Store as a Protocol with shared plain functions, so plan.md matches the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes phase 0 in the roadmap and replaces
plan.mdwith the phase 1 plan. It changes docs underdocs/internal/only. No code or public docs change.What changed
roadmap.md: phase 0 is closed on 2026-10-05 with PR Phase 0: documents, verification command, and measurements #2, and phase 1 is open. A note records how phase 0 changed later phases. The local target is a three-container stack. Fused retrieval needs plain vector indexes and an embedder from the caller. The integration tests can run against the local stack in CI. The phase 2 row now says so.plan.md: phase 1, the storage contract offline. It has ten tasks, seven acceptance criteria, and its stop conditions.For review
The plan takes four defaults on questions that the brief leaves open. Please confirm or change them before the phase 1 issue opens:
MemoryStoretakes an embedder.searchwith query text and no embedder raises.src/layout. It is built but not yet published to PyPI.Verification
make verifypasses.