Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #585.
Requesting an etree builder with
fullTree=False, thenTrue, thenFalsereturns a new class for the first configuration. Cache misses test literal keys while initializing the module and argument buckets, discarding previously cached configurations. A parser built with the earlier class can then fail anisinstancecheck against the class obtained again.Preserve those buckets when inserting a new configuration, and remove the redundant intermediate entry. Add factory and public tree-builder regressions, a changelog entry and author attribution.
Validation on Python 3.11.16/macOS arm64, using local
setuptools==70.3.0build/test constraints:py311-base: 17506 passed, 15885 skipped, 683 xfailed; flake8 passed.py311-optionalwithchardet==5.2.0: 23570 passed, 6038 skipped, 1017 xfailed; flake8 passed.The setuptools constraint avoids the existing
pkg_resourcespackaging failure. With current optional dependencies (chardet==7.7.0),test_char_win1252fails on both this branch and unchanged main. These are local compatibility constraints; repository requirements and test configuration are unchanged.AppVeyor 1.0.452:
py27-basepassed (22183 passed, 10874 skipped, 1017 xfailed), including flake8. The other jobs stop before tests: the launcher cannot find Python 3.7, and the Python 2.7 optional environment cannot build lxml without Visual C++ 9.0. The same setup failures appear in the preceding 1.0.451 build.