Skip to content

Fail, don't crash, when an expected request never reaches the origin #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnot merged 1 commit into from
Nov 3, 2026
Merged

Fail, don't crash, when an expected request never reaches the origin #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test-engine/client/test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ function checkServerRequests (requests, responses, serverState) {
})
if ('expected_request_headers' in reqConfig) {
const reqPresentSetup = setupCheck(reqConfig, 'expected_request_headers')
assert(reqPresentSetup, typeof (serverRequest) !== 'undefined', `request ${reqNum} wasn't sent to server`)
reqConfig.expected_request_headers.forEach(header => {
if (typeof header === 'string') {
const headerName = header.toLowerCase()
Expand All @@ -349,6 +350,7 @@ function checkServerRequests (requests, responses, serverState) {
}
if ('expected_request_headers_missing' in reqConfig) {
const reqmPresentSetup = setupCheck(reqConfig, 'expected_request_headers_missing')
assert(reqmPresentSetup, typeof (serverRequest) !== 'undefined', `request ${reqNum} wasn't sent to server`)
reqConfig.expected_request_headers_missing.forEach(header => {
if (typeof header === 'string') {
const headerName = header.toLowerCase()
Expand Down
Loading