Repository navigation
Add a TLS signing certificate setting - #287
Open
igolaizola wants to merge 1 commit into
Open
igolaizola wants to merge 1 commit into
igolaizola wants to merge 1 commit into
Conversation
|
|
There was a problem hiding this comment.
🔵 Needs a closer look
The server-side certificate-switching contract and successful save/restart path still need human validation.
1 open issue
What changed in this PR
Adds a TLS signing certificate selector to Pro proxy settings, connecting the choice to the server API and the existing restart flow.
Changes:
- Offers local, modern eMudhra, and legacy eMudhra certificate options based on server capabilities.
- Saves certificate changes before restarting and displays save failures without reloading.
- Adds six component tests covering selection, availability, restart visibility, and error handling.
| File | Description |
|---|---|
test/unit/components/settings/proxy-settings-card.spec.tsx |
Tests certificate selection and save-error behavior. |
src/services/server-rest-api.ts |
Adds the certificate configuration POST request. |
src/services/server-api.ts |
Exposes certificate updates through the REST client. |
src/services/server-api-types.ts |
Defines certificate modes and optional configuration fields. |
src/model/proxy-store.ts |
Tracks available, selected, and active certificate modes. |
src/components/settings/proxy-settings-card.tsx |
Adds the selector and save-before-restart handling. |
Review effort: Balanced
| yield this.props.proxyStore!.applyCertificateMode(); | ||
| window.location.reload(); | ||
| } catch (error) { | ||
| this.restartError = asError(error).message; |
Author
There was a problem hiding this comment.
Fixed. The handler now uses ApiError.apiError.message when available, with the existing error message as a fallback.
Offer local, modern eMudhra and legacy eMudhra CAs in Pro proxy settings. Save the choice through the server API and use the existing restart button. Tests: six component tests and source type checking pass.
igolaizola
force-pushed
the
emudhra-certificates
branch
from
October 22, 2026 19:19
67c9925 to
01780aa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offer local, modern eMudhra and legacy eMudhra CAs in Pro proxy settings. Save the choice through the server API and use the existing restart button.
Tests: six component tests and source type checking pass.