refactor lumina2 pipeline tests to the new mixin structure - #14629
Open
akshan-main wants to merge 1 commit into
Open
refactor lumina2 pipeline tests to the new mixin structure#14629akshan-main wants to merge 1 commit into
akshan-main wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the Lumina2 pipeline tests to the new mixin structure from #14113: a
Lumina2PipelineTesterConfigplusTestLumina2Pipeline(PipelineTesterMixin)andTestLumina2PipelineMemory(MemoryTesterMixin), with dummy inputs switched tooutput_type="pt"and a fresh CPU slice intest_inference.One note:
output_shapeis(3, 4, 4), since the dummy one-block VAE decodes the 4x4 latents at scale 1 (the old file never asserted an output shape, so the small size went unnoticed). This unblocks movingtests/lora/test_lora_layers_lumina2.pyto the pipeline-level LoRA mixins, which I will follow up with. Follows #14628.Before submitting
Who can review?
@sayakpaul