Skip to content

Review label management#1610

Merged
simongdavies merged 1 commit into
hyperlight-dev:mainfrom
simongdavies:review-label-management
Jul 2, 2026
Merged

Review label management#1610
simongdavies merged 1 commit into
hyperlight-dev:mainfrom
simongdavies:review-label-management

Conversation

@simongdavies

Copy link
Copy Markdown
Member

Two step process to remove ready-for-review label, allows for removing labels from a PR based on a fork.

Step 1 . Record the PR number that was updated (requires no write permissions) stores the PR number in an artefact tied to the workflow run.

Step 2. Runs when any Step 1 workflow completes, reads the PR number from the artefact and validates it, removes the Label from the PR if necessary

Copilot AI review requested due to automatic review settings July 2, 2026 11:49
@simongdavies simongdavies added the kind/bugfix For PRs that fix bugs label Jul 2, 2026
@simongdavies simongdavies requested a review from danbugs as a code owner July 2, 2026 11:49
@simongdavies simongdavies added the ready-for-review PR is ready for (re-)review label Jul 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “ready-for-review” label automation to a two-stage GitHub Actions pipeline so labels can be removed safely even when the triggering event originates from a fork (where the initial workflow only has a read-only token).

Changes:

  • Replaces the previous single workflow with a Stage 1 “collect” workflow that records the PR number as an artifact on pull_request / pull_request_review events.
  • Adds a Stage 2 “manage” workflow triggered by workflow_run that downloads and validates the artifact, then invokes the org reusable workflow to remove the label when appropriate.
  • Updates label documentation to reference the new collect/manage workflow pair.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/github-labels.md Updates docs to reflect the new two-workflow automation.
.github/workflows/ready-for-review-label.yml Renames/retools the workflow into Stage 1 “collect” that uploads the PR number artifact.
.github/workflows/ready-for-review-manage.yml Adds Stage 2 “manage” workflow that reads/validates the PR number and runs the privileged label removal.

Comment thread .github/workflows/ready-for-review-manage.yml
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
@simongdavies simongdavies force-pushed the review-label-management branch from 7b2aa89 to 835001a Compare July 2, 2026 11:56
@simongdavies simongdavies merged commit a214b54 into hyperlight-dev:main Jul 2, 2026
83 of 89 checks passed
@github-actions github-actions Bot removed the ready-for-review PR is ready for (re-)review label Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix For PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants