Skip to content

fix(ci): pin third-party actions to full commit SHAs - #46

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions
Sep 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

fix(ci): pin third-party actions to full commit SHAs

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — startup_failure, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. actions/checkout@<sha> # v4.

dtolnay/rust-toolchain takes its toolchain from the ref itself, so those steps also gained an
explicit with: toolchain: input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — `startup_failure`, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. `actions/checkout@<sha> # v4`.

`dtolnay/rust-toolchain` takes its toolchain from the ref itself, so those steps also gained an
explicit `with: toolchain:` input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 76fb22c5-8c2a-4934-96f8-8e996c26462d

📥 Commits

Reviewing files that changed from the base of the PR and between 513c1b8 and 8524deb.

📒 Files selected for processing (4)
  • .github/workflows/codeql.yml
  • .github/workflows/quality.yml
  • .github/workflows/release.yml
  • .github/workflows/sonarqube.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (19)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: rust-ci / Detect Cargo.toml
🧰 Additional context used
🪛 zizmor (1.30.0)
.github/workflows/release.yml

[info] 139-139: action functionality is already included by the runner (superfluous-actions): use gh release in a script step

(superfluous-actions)

🔇 Additional comments (4)
.github/workflows/codeql.yml (1)

42-47: LGTM!

.github/workflows/quality.yml (1)

33-33: LGTM!

.github/workflows/release.yml (1)

139-139: LGTM!

.github/workflows/sonarqube.yml (1)

34-34: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Pinned third-party CI/CD workflow actions to specific commit references.
    • Improved workflow reproducibility and protection against mutable action tags.
    • Preserved the existing CodeQL, quality checks, release, and SonarQube workflow behaviour.

Walkthrough

Four GitHub Actions references now use full commit SHAs. The workflows retain version comments and keep their existing configuration and behaviour.

Changes

Workflow action pinning

Layer / File(s) Summary
Pin workflow actions
.github/workflows/codeql.yml, .github/workflows/quality.yml, .github/workflows/release.yml, .github/workflows/sonarqube.yml
CodeQL, TruffleHog, release, and SonarQube action references now use full commit SHAs instead of version tags. Version comments remain in place.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose and intended behaviour, but it does not follow the repository template. It omits the required Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sec… Rewrite the description using the repository template. Add the required sections, list the changed workflows, record applicable checklist results, and describe the tests performed or state why testing was not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: pinning third-party CI actions to full commit SHAs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the purpose and intended behaviour, but it does not follow the repository template. It omits the required Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections, including test and checklist results.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each workflow line
Four actions now have pins precise
CodeQL and scans stay on their track
Releases hop, then wander back
Version notes remain in place
SHA marks guard the working space

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) September 19, 2026 23:23
@hyperpolymath
hyperpolymath merged commit 445bbbb into main Sep 20, 2026
22 of 27 checks passed
@hyperpolymath
hyperpolymath deleted the fix/sha-pin-actions branch September 20, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant