Skip to content

chore(ci): SPDX headers on line 1 and Actions lockfile minted - #45

Merged
hyperpolymath merged 2 commits into
mainfrom
chore/ci-hygiene-lockfile-spdx
Aug 7, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
chore/ci-hygiene-lockfile-spdx

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Two estate gates, one change.

SPDX — the linter checks head -1 only, so workflows carrying their identifier below a managed-by comment report as missing one. Each file's own identifier is moved to line 1; nothing is imposed (repos here are variously MPL-2.0, PMPL-1.0-or-later, AGPL-3.0-or-later). Licences in this repo: MPL-2.0.

Lockfile (minted)gh actions-lock resolves each symbolic ref to a verified commit plus owner_id, repo_id and the transitive dependencies of composite actions. That is what Scorecard's Pinned-Dependencies check wants, and what an inline SHA cannot express.

⚠ Do not additionally SHA-pin inline — the mechanisms are mutually exclusive, and inline pinning removes actions from the lockfile (measured on hypatia: 14 startup_failures).

Verified: all workflows parse · no duplicate SPDX identifiers · gh actions-lock --verify-local: All 8 workflows have complete lockfile coverage.

🤖 Generated with Claude Code

Two estate gates, one change.

**SPDX.** `governance / Workflow security linter` checks `head -1 | grep`, so a
workflow carrying its identifier below a managed-by comment reports as missing
one. Each file's OWN identifier is moved to line 1 — nothing is imposed, because
repositories here are variously MPL-2.0, PMPL-1.0-or-later and AGPL-3.0-or-later
and a default would mis-declare the minority. Licences seen here: MPL-2.0.

**Lockfile.** `gh actions-lock` resolves each symbolic ref to a verified commit
plus owner_id, repo_id and the transitive dependencies of composite actions —
which is what OSSF Scorecard's Pinned-Dependencies check is asking for, and what
an inline SHA cannot express.

⚠ Do NOT additionally SHA-pin inline. The mechanisms are mutually exclusive:
`gh actions-lock` refuses a ref no tag or branch contains, so inline pinning
REMOVES actions from the lockfile. Measured on hypatia 2026-08-07 — 40 inline
pins caused 14 startup_failures and dropped 7 lockfile entries.

Verified: all workflows parse, no duplicate identifiers, lockfile verify says
"All 8 workflows have complete lockfile coverage.".
Comment thread .github/workflows/hypatia-scan.yml Fixed
Comment thread .github/workflows/hypatia-scan.yml Fixed
Comment thread .github/workflows/scorecard.yml Fixed
Comment thread .github/workflows/scorecard.yml Fixed
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 19 issues detected

Severity Count
🔴 Critical 0
🟠 High 13
🟡 Medium 6
View findings
[
  {
    "reason": "Issue in push-email-notify.yml",
    "type": "missing_timeout_minutes",
    "file": "push-email-notify.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "6 workflow(s) with tag-pinned (not SHA-pinned) actions in lucidscript",
    "type": "DependencyPinning",
    "file": "/home/runner/work/lucidscript/lucidscript",
    "action": "auto_fix",
    "rule_module": "scorecard",
    "severity": "medium",
    "remediation": "Pin GitHub Actions and Docker base images by SHA hash.",
    "scorecard_check": "Pinned-Dependencies"
  },
  {
    "reason": "Code scanning (Scorecard): TokenPermissionsID -- Token-Permissions -- 16 day(s) old [STALE]",
    "type": "CSA001",
    "file": ".github/workflows/scorecard.yml",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  },
  {
    "reason": "Code scanning (Scorecard): BranchProtectionID -- Branch-Protection -- 42 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  },
  {
    "reason": "Code scanning (Hypatia): hypatia/workflow_audit/missing_timeout_minutes -- Hypatia workflow_audit: missing_timeout_minutes -- 43 day(s) old [STALE]",
    "type": "CSA001",
    "file": "push-email-notify.yml",
    "action": "update",
    "rule_module": "code_scanning_alerts",
    "severity": "medium"
  },
  {
    "reason": "Code scanning (Scorecard): SASTID -- SAST -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "update",
    "rule_module": "code_scanning_alerts",
    "severity": "medium"
  },
  {
    "reason": "Code scanning (Scorecard): FuzzingID -- Fuzzing -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "update",
    "rule_module": "code_scanning_alerts",
    "severity": "medium"
  },
  {
    "reason": "Code scanning (Scorecard): MaintainedID -- Maintained -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  },
  {
    "reason": "Code scanning (Scorecard): CodeReviewID -- Code-Review -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  },
  {
    "reason": "Code scanning (Scorecard): TokenPermissionsID -- Token-Permissions -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": ".github/workflows/hypatia-scan.yml",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@gitar-bot

This comment has been minimized.

@gitar-bot
gitar-bot Bot enabled auto-merge (squash) August 7, 2026 12:01
gitar-bot[bot]
gitar-bot Bot previously approved these changes Aug 7, 2026

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR and enabled auto-merge (configure)

`gh actions-lock` inserts `# This workflow is managed by gh actions-lock.` at
line 1, which displaced the SPDX identifier moved there earlier in this branch.
The linter greps `head -1` only, so the header read as missing again.

Each file's OWN identifier is moved back to line 1 — nothing imposed. Files
already correct are untouched, and any file carrying two identifiers aborts the
change rather than guessing.
@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 19 issues detected

Severity Count
🔴 Critical 0
🟠 High 13
🟡 Medium 6
View findings
[
  {
    "reason": "Issue in push-email-notify.yml",
    "type": "missing_timeout_minutes",
    "file": "push-email-notify.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "6 workflow(s) with tag-pinned (not SHA-pinned) actions in lucidscript",
    "type": "DependencyPinning",
    "file": "/home/runner/work/lucidscript/lucidscript",
    "action": "auto_fix",
    "rule_module": "scorecard",
    "severity": "medium",
    "remediation": "Pin GitHub Actions and Docker base images by SHA hash.",
    "scorecard_check": "Pinned-Dependencies"
  },
  {
    "reason": "Code scanning (Scorecard): TokenPermissionsID -- Token-Permissions -- 16 day(s) old [STALE]",
    "type": "CSA001",
    "file": ".github/workflows/scorecard.yml",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  },
  {
    "reason": "Code scanning (Scorecard): BranchProtectionID -- Branch-Protection -- 42 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  },
  {
    "reason": "Code scanning (Hypatia): hypatia/workflow_audit/missing_timeout_minutes -- Hypatia workflow_audit: missing_timeout_minutes -- 43 day(s) old [STALE]",
    "type": "CSA001",
    "file": "push-email-notify.yml",
    "action": "update",
    "rule_module": "code_scanning_alerts",
    "severity": "medium"
  },
  {
    "reason": "Code scanning (Scorecard): SASTID -- SAST -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "update",
    "rule_module": "code_scanning_alerts",
    "severity": "medium"
  },
  {
    "reason": "Code scanning (Scorecard): FuzzingID -- Fuzzing -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "update",
    "rule_module": "code_scanning_alerts",
    "severity": "medium"
  },
  {
    "reason": "Code scanning (Scorecard): MaintainedID -- Maintained -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  },
  {
    "reason": "Code scanning (Scorecard): CodeReviewID -- Code-Review -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": "no file associated with this alert",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  },
  {
    "reason": "Code scanning (Scorecard): TokenPermissionsID -- Token-Permissions -- 50 day(s) old [STALE]",
    "type": "CSA001",
    "file": ".github/workflows/hypatia-scan.yml",
    "action": "escalate",
    "rule_module": "code_scanning_alerts",
    "severity": "high"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@hyperpolymath
hyperpolymath disabled auto-merge August 7, 2026 15:26
@hyperpolymath
hyperpolymath merged commit 4dd5866 into main Aug 7, 2026
4 of 5 checks passed
@hyperpolymath
hyperpolymath deleted the chore/ci-hygiene-lockfile-spdx branch August 7, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants