-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): pin third-party actions to full commit SHAs #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,9 +21,9 @@ jobs: | |
| image: ghcr.io/stefan-hoeck/idris2-pack@sha256:f0758996a931fb35d9ecb1de273c4d59dabe2a09b433afc7e357f65a08b7e1ff | ||
| steps: | ||
| - name: Checkout Site | ||
| uses: actions/checkout@v7.0.1 | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - name: Checkout Ddraig SSG | ||
| uses: actions/checkout@v7.0.1 | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| repository: hyperpolymath/ddraig-ssg | ||
| path: .ddraig-ssg | ||
|
|
@@ -40,7 +40,7 @@ jobs: | |
| fi | ||
| ./.ddraig-ssg/build/exec/ddraig build src _site https://hyperpolymath.github.io/${GITHUB_REPOSITORY#*/} | ||
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v5.0.0 | ||
| uses: actions/upload-pages-artifact@fc324d3547104276b827a68afc52ff2a11cc49c9 # v5.0.0 | ||
| with: | ||
| path: '_site' | ||
| deploy: | ||
|
|
@@ -53,4 +53,4 @@ jobs: | |
| steps: | ||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v5.0.1 | ||
| uses: actions/deploy-pages@368f82528645a54fb793d4d04e342629a3f51346 # v5.0.1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: set -eu
printf '%s\n' '--- workflow entries ---'
sed -n '45,65p' .github/workflows/pages.yml
sed -n '34,50p' .github/workflows/push-email-notify.yml
printf '%s\n' '--- lockfile references ---'
rg -n -C 4 'deploy-pages|smtp-notify-action|actions/deploy-pages|v5\.0\.0|v5\.0\.1|v0\.2\.0|ede1191|22e7bdb|368f825' .github/workflows/actions.lock .github/workflows 2>/dev/null
printf '%s\n' '--- tracked related files ---'
git ls-files .github/workflows | sortRepository: hyperpolymath/lucidscript Length of output: 10409 🤖 get_repo_knowledge executed:
Length of output: 1161 🏁 Script executed: set -eu
printf '%s\n' '--- actions.lock header and relevant structure ---'
sed -n '1,115p' .github/workflows/actions.lock
printf '%s\n' '--- repository references to actions.lock and pin authority ---'
rg -n -C 3 'actions\.lock|pin authority|NOSONAR|workflow.*pin|SHA.*pin|lockfile' .github README.md . 2>/dev/null | head -n 240
printf '%s\n' '--- relevant workflow comments and action refs ---'
rg -n -C 2 'uses:|actions\.lock|NOSONAR' .github/workflows/pages.yml .github/workflows/push-email-notify.ymlRepository: hyperpolymath/lucidscript Length of output: 15573 Synchronise the workflow pins with
📍 Affects 2 files
🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Keep one
withblock and retainstable.The Radicle step now contains a second
withmapping. The existingwith: toolchain: stableblock remains on Lines 149-150. YAML mappings require unique keys, so this workflow is invalid under the YAML mapping rules. (yaml.org)The change also replaces
stablewithmaster.dtolnay/rust-toolchainpasses this value torustup toolchain install, butmasteris not a standard Rust release-channel specification. Keep one block withtoolchain: stableto preserve the workflow behaviour. (github.com)Proposed fix
- name: Setup Rust uses: dtolnay/rust-toolchain@02cb101ec7c40f2c49e1d9714d64511d8e1b74de # master - with: - toolchain: master with: toolchain: stable📝 Committable suggestion
🤖 Prompt for AI Agents
Source: MCP tools