Skip to content

fix(ci): pin third-party actions to full commit SHAs - #109

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions
Sep 19, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

fix(ci): pin third-party actions to full commit SHAs

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — startup_failure, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. actions/checkout@<sha> # v4.

dtolnay/rust-toolchain takes its toolchain from the ref itself, so those steps also gained an
explicit with: toolchain: input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — `startup_failure`, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. `actions/checkout@<sha> # v4`.

`dtolnay/rust-toolchain` takes its toolchain from the ref itself, so those steps also gained an
explicit `with: toolchain:` input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c5d2284d-518e-44da-9d5a-3229d6d16f5f

📥 Commits

Reviewing files that changed from the base of the PR and between 260798b and 55b060c.

📒 Files selected for processing (19)
  • .github/workflows/boj-build.yml
  • .github/workflows/codeql.yml
  • .github/workflows/coordination-boundary.yml
  • .github/workflows/dependabot-automerge.yml
  • .github/workflows/dogfood-gate.yml
  • .github/workflows/guix-nix-policy.yml
  • .github/workflows/instant-sync.yml
  • .github/workflows/openssf-compliance.yml
  • .github/workflows/pages.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/quality.yml
  • .github/workflows/release.yml
  • .github/workflows/rhodibot.yml
  • .github/workflows/rsr-antipattern.yml
  • .github/workflows/runtime-policy.yml
  • .github/workflows/security-policy.yml
  • .github/workflows/static-analysis-gate.yml
  • .github/workflows/wellknown-enforcement.yml
  • .github/workflows/workflow-linter.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (13)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: scan / shell-secrets
🔇 Additional comments (19)
.github/workflows/boj-build.yml (1)

30-30: LGTM!

.github/workflows/coordination-boundary.yml (1)

31-31: LGTM!

.github/workflows/dogfood-gate.yml (1)

30-30: LGTM!

Also applies to: 75-75, 92-92, 125-125, 190-190, 249-249, 315-315

.github/workflows/guix-nix-policy.yml (1)

25-25: LGTM!

.github/workflows/openssf-compliance.yml (1)

24-24: LGTM!

.github/workflows/pages.yml (1)

23-23: LGTM!

Also applies to: 25-25, 42-42, 55-55

.github/workflows/rhodibot.yml (1)

37-37: LGTM!

.github/workflows/rsr-antipattern.yml (1)

28-28: LGTM!

.github/workflows/runtime-policy.yml (1)

40-40: LGTM!

.github/workflows/security-policy.yml (1)

25-25: LGTM!

.github/workflows/static-analysis-gate.yml (1)

27-27: LGTM!

Also applies to: 130-130, 152-152, 159-159, 266-266, 288-288, 355-355, 380-380, 386-386, 392-392, 454-454

.github/workflows/wellknown-enforcement.yml (1)

29-29: LGTM!

.github/workflows/workflow-linter.yml (1)

28-28: LGTM!

.github/workflows/codeql.yml (1)

43-43: LGTM!

Also applies to: 46-46, 52-52

.github/workflows/dependabot-automerge.yml (1)

59-59: LGTM!

.github/workflows/instant-sync.yml (1)

34-34: LGTM!

.github/workflows/push-email-notify.yml (1)

43-43: LGTM!

.github/workflows/quality.yml (1)

26-26: LGTM!

Also applies to: 33-33, 50-50, 59-59

.github/workflows/release.yml (1)

26-26: LGTM!

Also applies to: 90-90, 120-120, 134-134, 143-143


📝 Summary

Summary by CodeRabbit

  • Security
    • Pinned GitHub Actions to immutable commit references across build, quality, security, compliance, deployment, and release workflows.
    • Reduced the risk of workflows unexpectedly changing when version tags or branches are updated.
    • Preserved existing workflow behaviour, permissions, and job logic.

Walkthrough

This change replaces mutable GitHub Actions tags and branches with commit SHA references across 19 workflow files. Version comments remain where supplied. Workflow jobs, permissions, and control flow are unchanged.

Changes

Workflow action pinning

Layer / File(s) Summary
Checkout action pins
.github/workflows/boj-build.yml, .github/workflows/coordination-boundary.yml, .github/workflows/dogfood-gate.yml, .github/workflows/guix-nix-policy.yml, .github/workflows/openssf-compliance.yml, .github/workflows/pages.yml, .github/workflows/rhodibot.yml, .github/workflows/rsr-antipattern.yml, .github/workflows/runtime-policy.yml, .github/workflows/security-policy.yml, .github/workflows/static-analysis-gate.yml, .github/workflows/wellknown-enforcement.yml, .github/workflows/workflow-linter.yml
Checkout references now use fixed commit SHAs instead of mutable version tags.
Workflow-specific action pins
.github/workflows/codeql.yml, .github/workflows/dependabot-automerge.yml, .github/workflows/dogfood-gate.yml, .github/workflows/instant-sync.yml, .github/workflows/pages.yml, .github/workflows/push-email-notify.yml, .github/workflows/quality.yml, .github/workflows/release.yml
CodeQL, Dependabot, validation, dispatch, Pages, notification, quality, and release actions now use fixed commit SHAs.
Static analysis action pins
.github/workflows/static-analysis-gate.yml
BEAM setup and artifact upload and download actions now use fixed commit SHAs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose and intended behaviour, but it does not follow the repository template. It omits the required Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sec… Add the required template sections. List the key changes, complete the RSR Quality Checklist, describe the tests performed, and state whether screenshots or terminal output apply. Preserve the existing explanation in the Summary section and…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: pinning third-party GitHub Actions to full commit SHAs. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the purpose and intended behaviour, but it does not follow the repository template. It omits the required Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections.

Resolution

Add the required template sections. List the key changes, complete the RSR Quality Checklist, describe the tests performed, and state whether screenshots or terminal output apply. Preserve the existing explanation in the Summary section and include the dtolnay/rust-toolchain toolchain-input changes if they are part of the pull request, because they are not reflected in the provided file summaries or raw changeset summary.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each workflow line
Tags become commits, neat and fine
The jobs still hop along their way
With version notes to mark the day
SHA-stable paths now lead the play

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 5b92153 into main Sep 19, 2026
23 of 24 checks passed
@hyperpolymath
hyperpolymath deleted the fix/sha-pin-actions branch September 19, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant