Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #74

Merged
hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f61ef61f-b7c1-42b9-8bf3-6df83a0f6f1e

📥 Commits

Reviewing files that changed from the base of the PR and between d022f9e and b41a236.

📒 Files selected for processing (3)
  • .github/workflows/governance.yml
  • .github/workflows/mirror.yml
  • .github/workflows/rust-ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (27)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: panic-attack assail
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: validate
  • GitHub Check: Validate A2ML manifests
🔇 Additional comments (3)
.github/workflows/governance.yml (1)

17-20: LGTM!

.github/workflows/mirror.yml (1)

16-19: LGTM!

.github/workflows/rust-ci.yml (1)

18-21: LGTM!


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Corrected workflow permission placement so required read and security-event permissions are applied at the appropriate job level.
    • Updated governance, mirroring, and Rust CI workflows for consistent permission handling.

Walkthrough

The three reusable workflow jobs now place their existing actions, contents, and security-events permissions at job level. The permission values are unchanged.

Changes

Workflow permission placement

Layer / File(s) Summary
Correct job-level permissions
.github/workflows/governance.yml, .github/workflows/mirror.yml, .github/workflows/rust-ci.yml
The three jobs declare the existing permissions at job level instead of nesting them under uses.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the YAML indentation problem and the intended fix, but it omits the required template sections, checklist status, and testing details. Complete the required template. Add the Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections. Mark applicable checklist items and state how YAML parsing was validated.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: repairing invalid CI workflow permissions indentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow nest
Permissions sit where YAML works best
Actions read and contents too
Security events write as due
Three jobs now show the right address

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit c556989 into main Sep 21, 2026
23 of 29 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant