chore(governance): stop declaring repository identity in settings.yml - #76
Merged
Merged
Conversation
probot/settings applies this file on every push to the default branch, so `name`,
`description`, `homepage` and `private` here are instructions, not documentation. The estate has
already paid for that: the template carried `name: "{{REPO}}"`, GitHub collapsed the illegal braces
to dashes, the repo renamed itself to `-REPO-` on every push and its old URL 404'd.
This file now matches the template's own header and rule, with the four identity keys removed and
everything else left as it was. Repository identity and visibility are set out of band, once, by
the owner. Enforced by scripts/check-no-placeholders.sh.
|
Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probot/settingsapplies this file on every push to the default branch, so the four identitykeys it declared are instructions, not documentation. The estate has already paid for exactly this:
.github/settings.ymlonce readname: "{{REPO}}", GitHub collapsed the illegal braces to dashes,the repository renamed itself to
-REPO-on every push, its old URL 404'd, and it was read as adeleted repository.
This repo still declared
name,description,homepageandprivate.The repair is convergence on the source of truth, not new content:
("THIS FILE MUST NEVER DECLARE REPOSITORY IDENTITY");
same 18 labels;
Verified with the estate's own gate,
scripts/check-no-placeholders.sh, whose settings.yml guardruns in template repos too (that exemption is how the original incident went unseen). On this
branch the guard reports clean.