fix(asq): foundational remediation for airborne-submarine-squadron - #1047
Merged
Merged
Conversation
…ne-squadron - Fix canvas restore stack leak in drawEvelCameratron() - Fix missing modular script tags in index.html - Re-sync actions.lock with CodeQL action bump v4.38.1 - Fix SPDX header position and workflow linter compatibility - Fix www/.well-known path in compatibility tests - Restore prebuilt WASM artifact to build/ and dist/ - Document GitHub Pages configuration requirements for #60 Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
arena-ai-coding-agent
Bot
requested a review
from hyperpolymath
as a code owner
September 24, 2026 20:58
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
approved these changes
Sep 24, 2026
hyperpolymath
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR supplies the foundational remediation patch for
hyperpolymath/airborne-submarine-squadron(resolving open issue #60 and related physics/rendering bugs).What is Included
Rendering & Physics Fix:
drawEvelCameratron(): Fixed an unbalancedctx.restore()ingossamer/app_gossamer.js(2 saves vs 3 restores), which previously popped the global camera transformation matrix, throwing island entities and coordinates to raw screen positions and causing violent jumping/flickering.index.html: Restored modular script tags (sfx.js,terrain.js,enemies.js,hud.js,weapons.js,orbital.js,controls.js,persist.js) sogetGroundYandislandHitTestare present when playing through the root entry point, preventing the submarine from plunging through the seabed.CI Workflows & Stability:
.github/workflows/actions.lockwith Dependabot's bump ofgithub/codeql-actiontov4.38.1(sha1-1c5b675653bb5c22dbe9b12b556ec555138e09fd).workflow-linter.ymlto check the leading comment block rather than strictly line 1, avoiding false-positive failures caused bygh actions-lockheaders.test/compatibility_test.jsto resolvewww/.well-known/groove/manifest.jsonfollowing PR Phase A — Contract definition + policy-authoring workflow + example Verb Governance Spec #96 migration.Deliverable:
patches/airborne-submarine-squadron.patch