-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): pin third-party actions to full commit SHAs #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,10 +25,10 @@ jobs: | |
| timeout-minutes: 15 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v7.0.1 | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| fetch-depth: 0 # full history for accurate new-code detection | ||
| - name: SonarQube Scan | ||
| uses: SonarSource/sonarqube-scan-action@v8.2.1 | ||
| uses: SonarSource/sonarqube-scan-action@22918119ff8e1ca75a623e15c8296b6ea4fbe28f # v8.2.1 | ||
|
Comment on lines
+28
to
+32
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: #!/usr/bin/env bash
set -euo pipefail
gh actions-lock --verify-local
for sha in \
3d3c42e5aac5ba805825da76410c181273ba90b1 \
b96794f015dfd88f77b49b1c93e0fa7110f94c63 \
51f63319f592f97930c73d9c46184d20bd206393 \
55cc8345863c7cc4c66a329aec7e433d2d1c52a9 \
22918119ff8e1ca75a623e15c8296b6ea4fbe28f \
043fb46d1a93c77aae656e7c1c64a875d1fc6a0a \
54075bcc5e249e4758d363f27d099f55d843f124 \
3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c
do
rg -n "$sha" .github/workflows/actions.lock
doneRepository: hyperpolymath/systemet Length of output: 579 🏁 Script executed: set -euo pipefail
printf '%s\n' '--- workflow pins ---'
cat -n .github/workflows/sonarqube.yml | sed -n '20,38p'
printf '%s\n' '--- lockfile matching entries ---'
rg -n -C 2 -i 'actions/checkout|sonarsource/sonarqube-scan-action|3d3c42e5aac5ba805825da76410c181273ba90b1|22918119ff8e1ca75a623e15c8296b6ea4fbe28f|v7\.0\.1|v8\.2\.1' .github/workflows/actions.lock
printf '%s\n' '--- linter references ---'
rg -n -C 4 'actions\.lock|actions-lock|verify-local' .github/workflows workflow* .github 2>/dev/null | head -200Repository: hyperpolymath/systemet Length of output: 18359 🏁 Script executed: printf '%s\n' '--- lockfile ---'
rg -n -C 3 -i 'actions/checkout|sonarsource/sonarqube-scan-action|3d3c42e5aac5ba805825da76410c181273ba90b1|22918119ff8e1ca75a623e15c8296b6ea4fbe28f|v7\.0\.1|v8\.2\.1' .github/workflows/actions.lock || true
printf '%s\n' '--- linter ---'
rg -n -C 3 'actions-lock|verify-local|actions\.lock' .github/workflows .github 2>/dev/null || trueRepository: hyperpolymath/systemet Length of output: 39085 🏁 Script executed: set -euo pipefail
for file in .github/workflows/codeql.yml .github/workflows/quality.yml .github/workflows/proofs.yml .github/workflows/static-analysis-gate.yml; do
printf '%s\n' "--- $file uses ---"
rg -n '^[[:space:]]+uses:' "$file" || true
done
printf '%s\n' '--- lockfile dependency records for the requested workflows ---'
sed -n '5,73p' .github/workflows/actions.lock
printf '%s\n' '--- matching dependency records ---'
rg -n -A5 -B1 -i 'actions/checkout@|github/codeql-action@|actions/cache@|editorconfig-checker/action-editorconfig-checker@|actions/download-artifact@|actions/upload-artifact@|erlef/setup-beam@' .github/workflows/actions.lockRepository: hyperpolymath/systemet Length of output: 9927 Regenerate the lockfile for the CodeQL pin.
gh extension install github/gh-actions-lock
gh actions-lock🤖 Prompt for AI AgentsSource: MCP tools |
||
| env: | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep the original
v0.3.0ref in the trailing comment.This line retains the
NOSONARnote, but it does not identify the ref replaced by22e7bdb322c430c1d0dac6b3bb307f4bb139d0be. Addv0.3.0so reviewers can audit the pin without consulting another file.🤖 Prompt for AI Agents