Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #207

Merged
hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 325e22f2-77a5-4ad7-8f9c-84e03027a3d4

📥 Commits

Reviewing files that changed from the base of the PR and between eab17bf and 8747f68.

📒 Files selected for processing (3)
  • .github/workflows/governance.yml
  • .github/workflows/mirror.yml
  • .github/workflows/secret-scanner.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (33)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / shell-secrets
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: spark-theatre-gate / SPARK Theatre Gate
  • GitHub Check: SQLite — generated overlay applies and views build
  • GitHub Check: Idris2 — machine-check ABI proofs
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: Zig — build + test FFI reference impl
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: ABI ↔ FFI structural conformance
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Groove manifest check
  • GitHub Check: Zig FFI builds + tests (Zig 0.14.0)
  • GitHub Check: cargo check (stable)
  • GitHub Check: Codegen — golden sample is up to date
  • GitHub Check: panic-attack assail
  • GitHub Check: analyze (rust)
🔇 Additional comments (3)
.github/workflows/governance.yml (1)

35-38: LGTM!

.github/workflows/mirror.yml (1)

16-19: LGTM!

.github/workflows/secret-scanner.yml (1)

20-23: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated automated workflow configuration to ensure job permissions are applied consistently.
    • Security scanning, mirroring, and governance checks continue to use the intended read and security-event access levels.
    • No user-facing functionality or product behaviour has changed.

Walkthrough

Three GitHub Actions workflows now place unchanged permissions blocks directly under their jobs. The blocks grant actions: read, contents: read, and security-events: write.

Changes

Workflow permission placement

Layer / File(s) Summary
Job-level permission declarations
.github/workflows/governance.yml, .github/workflows/mirror.yml, .github/workflows/secret-scanner.yml
The three workflows move their permissions blocks to job level. Permission values remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the cause and intended fix, but it does not use the required template sections or provide the required checklist, testing details, or screenshots information. Rewrite the description with the required Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections. Complete the applicable checklist items and state the exact YAML validation performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: repairing invalid CI workflow permissions indentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow lines
Permissions sit where YAML assigns
Read actions, contents too
Security events now come through
Three jobs follow the proper signs

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 413bee7 into main Sep 21, 2026
31 of 36 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant