Skip to content

Read testOnBorrow correctly from config#316

Merged
suddendust merged 3 commits into
mainfrom
readTestOnBorrowFromConfigCorrectly
Jul 3, 2026
Merged

Read testOnBorrow correctly from config#316
suddendust merged 3 commits into
mainfrom
readTestOnBorrowFromConfigCorrectly

Conversation

@suddendust

Copy link
Copy Markdown
Contributor

Description

There was a bug in the earlier PR that it was not reading this key from the config. This PR fixes it. Test this in a live env:

2026-07-02 07:44:50.032 [main] DEBUG o.h.c.d.p.PostgresConnectionPool - Postgres connection pool properties - maxTotal: 10, maxIdle: 2, minIdle: 1, maxWaitMillis: 10000, connectionSurrenderTimeout: PT5M, testOnBorrow: false

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.44%. Comparing base (7c419db) to head (ae0ddf9).

Files with missing lines Patch % Lines
...config/TypesafeConfigDatastoreConfigExtractor.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #316      +/-   ##
============================================
- Coverage     81.44%   81.44%   -0.01%     
- Complexity     1550     1552       +2     
============================================
  Files           242      242              
  Lines          7519     7524       +5     
  Branches        727      728       +1     
============================================
+ Hits           6124     6128       +4     
  Misses          943      943              
- Partials        452      453       +1     
Flag Coverage Δ
integration 81.44% <80.00%> (-0.01%) ⬇️
unit 55.54% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Test Results

  124 files  ±0    124 suites  ±0   41s ⏱️ +5s
  842 tests +2    841 ✅ +2  1 💤 ±0  0 ❌ ±0 
1 179 runs  +2  1 178 ✅ +2  1 💤 ±0  0 ❌ ±0 

Results for commit ae0ddf9. ± Comparison against base commit 7c419db.

♻️ This comment has been updated with latest results.

@suddendust suddendust merged commit c9d3e0a into main Jul 3, 2026
6 of 7 checks passed
@suddendust suddendust deleted the readTestOnBorrowFromConfigCorrectly branch July 3, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants