Fix pool cleanup and keepalive reconnection races

[binaryfire]

This fixes two coroutine races in the pool lifecycle, reported during review of #572. One can skip an object's cleanup; the other waits for a socket that has already been closed and reports a misleading timeout.

Object pool cleanup

A lifetime sweep or idle trim can pause while destroying an expired object. If another coroutine closes the pool and pauses while destroying a different object, maintenance can resume and remove a healthy object from the closed channel. Returning that object to the channel fails, leaving its destroy callback uncalled and its managed entry behind.

A rejected requeue now destroys the object through the pool's existing cleanup path. The regression tests hold both cleanup operations at the relevant points and verify that every object is destroyed exactly once and the pool finishes empty.

Keepalive reconnection

When two connection attempts overlap, the losing attempt closes its unused socket. The winning socket can close while that cleanup is waiting. Reconnection then returns false, but call() previously ignored the result and waited until wait_timeout before throwing SocketPopException.

call() now checks the result and throws ConnectionException immediately when reconnection completes without an available socket. Reconnection also returns the actual connected state after heartbeat setup, covering closure during timer creation. Existing exceptions and cancellation continue to propagate without an additional reconnect attempt.

The connection contract and keepalive documentation describe these results. Tests cover both closure paths, including callback execution, socket cleanup, and timer cleanup.

Validation

PHPStan, PHP formatting checks, and the object-pool and connection-pool package suites pass. The new regressions were also run against the original implementations and fail for the reported reasons.

Addresses the object cleanup comment and keepalive reconnect comment.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: db869055-71f5-4f8a-9056-8b3f43939bbe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}