Conversation
mag_calibration_time has shipped in 9.1 and 10.x for a long time (default 30, range 20 to 120), but the calibration tab and compass pages still state 30 seconds as a fixed duration. Someone who raises the value reads that the beep comes after 30 seconds and stops moving the aircraft too early.
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding |
PR Summary by QodoDocument configurable compass calibration duration
AI Description
High-Level Assessment
Files changed (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mag_calibration_timehas shipped in 9.1 and 10.x for a long time (default 30, range 20 to 120 seconds), but two pages describe the magnetometer calibration as taking a fixed 30 seconds:docs/04-inav-configurator/calibration-tab.mdx:84— "You have 30 seconds to hold the copter in the air"docs/04-inav-configurator/calibration-tab.mdx:92— "After 30 seconds, the flight controller will sound a single beep"docs/05-core-features/compass.mdx:200— "Within 30 seconds, hold the aircraft in the air"docs/05-core-features/compass.mdx:217— "After 30 seconds, the flight controller will sound a single beep"Someone who raises the value follows the text, stops moving the aircraft after 30 seconds and ends up with a half-finished calibration.
Change
Those four sentences now name the setting and its range instead of a fixed number. Wording only, no restructuring, and the other "30 seconds" mentions in the docs (gyro auto-calibration, autoland wind estimation, PID tuning) are untouched because they are unrelated.
Source
mag_calibration_timeindocs/Settings.mdon bothrelease/9.1andmaintenance-10.x: default 30, min 20, max 120, "Adjust how long time the Calibration of mag will last."