test: cover migrated structural-properties signatures - #2785
Merged
Conversation
Add argument-coverage tests for the 37 functions of the structural-properties ellipsis migration (R/structural-properties.R, R/components.R, R/paths.R, and connect() from R/games.R): every keyword-only tail argument is passed by name with a non-default value and asserted on, and the legacy positional form is exercised through lifecycle::expect_deprecated() with an equality check against the equivalent named call. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argument-coverage tests for the 37 functions migrated in the already-merged
#2759 (structural-properties, incl. components, paths, and
connect()).For every migrated function:
non-default value and a real assertion (gaps only — existing named
coverage was reused, not duplicated);
and emits the soft deprecation
(
lifecycle::expect_deprecated()+ equality against the named call).Tallies:
^structural-properties$FAIL 0 · PASS 326;^components$FAIL 0 · PASS 54;^paths$FAIL 0 · PASS 28.Notes:
igraph.vs/igraph.esare compared withexpect_equal()/expect_identical_graphs()— every call mints a freshweakref
envattribute, soidentical()is FALSE by construction.shortest_paths(inbound.edges = TRUE)works arounda pre-existing
mainbug (create_es()rejects the 0 sentinel;fixed independently on feat: expose widest paths functions as
widest_paths()andwidest_path_widths()#2408) by settingreturn.vs.es = FALSE.feedback_arc_set/feedback_vertex_setblocks use the file'sskip_if_no_glpk()convention.Part of the lifecycle/coverage exercise on top of the #2782 baseline.
Generated by Claude Code