fix: name norm_coords() arguments at the rglplot.igraph() call site - #2801
Merged
Conversation
The nightly `rcc: ubuntu-26.04 (4.6) with lifecycle errors` leg fails in
'test-plot.R:85' ("rglplot() works"):
Error: Calling `norm_coords()` with positional or abbreviated
arguments was deprecated in igraph 3.0.0.
`rglplot.igraph()` still calls `norm_coords()` positionally,
an indirect soft deprecation that only this leg surfaces.
#2799 named the arguments at the 2-D `plot.igraph()` call site
but missed this second, 3-D one.
Name the arguments here as well,
so the call no longer routes through the migration shim.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
krlmlr
force-pushed
the
claude/fix-main-ci-2
branch
from
July 28, 2026 07:00
81958af to
4cb4a64
Compare
main CI green (positional norm_coords() in rglplot(), undeclared R_getRegisteredNamespace())main CI green (positional norm_coords() in rglplot(), R_getRegisteredNamespace() absent from the CSAN sanitizer image)
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4cb4a64 is merged into main:
|
krlmlr
force-pushed
the
claude/fix-main-ci-2
branch
from
July 28, 2026 07:42
4cb4a64 to
d3bdec3
Compare
main CI green (positional norm_coords() in rglplot(), R_getRegisteredNamespace() absent from the CSAN sanitizer image)norm_coords() arguments at the rglplot.igraph() call site
krlmlr
enabled auto-merge (squash)
July 28, 2026 07:47
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if d3bdec3 is merged into main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the sole red leg of the scheduled full rcc matrix on
main,rcc: ubuntu-26.04 (4.6) with lifecycle errors:#2799 named the arguments at
plot.igraph()'s 2-D call site but missedthe 3-D one in
rglplot.igraph().The leg only runs on schedule or manual dispatch
(the versions-matrix step is skipped on same-repo PRs),
so PR runs never surfaced it.
The fix names
xmin/xmax/ymin/ymax/zmin/zmaxat the caller —no verbosity pin, per the fix-the-caller policy.
Validation (with
libglu1-mesa+ rgl installed sorglplot() worksactually runs instead of skipping):
full suite FAIL 0 both plain and with
IGRAPH_LIFECYCLE_ERRORS=true;generator,
air, anddevtools::document()are no-ops.Not addressed here (deliberately):
the nightly Sanitizer failure
(
R_getRegisteredNamespaceundeclared on the CSAN image)was removed from this PR per maintainer request
and remains open;
the Bioconductor
graphpak outage and the sandbox-onlygraphsdb fetch are environmental.