Repository navigation
Conversation
PR SummaryReplaced three dead external references in resilience READMEs with active equivalents (HTTP 200 OK). Updated links to current, maintained sources: circuit-breaker/README.md now points to Spring Cloud Circuit Breaker docs at Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 87d48fa: docs: fix broken reference links in resilience READMEs
Files Processed (3)
- circuit-breaker/README.md (1 hunk)
- fallback/README.md (1 hunk)
- microservices-load-shedding/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
-
circuit-breaker/README.md [196-196]
best_practice: "Replace broken external reference with official docs"
-
fallback/README.md [94-94]
maintainability: "Add resilience4j Fallback doc reference"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3629 +/- ##
=========================================
Coverage 84.06% 84.07%
- Complexity 4353 4354 +1
=========================================
Files 1133 1133
Lines 15400 15400
Branches 739 739
=========================================
+ Hits 12946 12947 +1
Misses 2158 2158
+ Partials 296 295 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What: replaced/removed 3 dead external reference links in resilience-pattern READMEs (Spring guide 404, Resilience4j docs 404, microservices.io 404).
Why: the old URLs return HTTP 404; replacements verified HTTP 200 and cover the same topics.
How verified: curl HEAD/GET on old (404) and new (200) URLs; git diff reviewed; no other lines touched.
No linked issue; same-repo precedent: #3409, #3394, #1525 (merged broken-link fixes).