Skip to content

docs: fix broken reference links in resilience READMEs - #3629

Open
pei711 wants to merge 1 commit into
iluwatar:masterfrom
pei711:contrib/fix-resilience-doc-links
Open

pei711 wants to merge 1 commit into
iluwatar:masterfrom
pei711:contrib/fix-resilience-doc-links

Conversation

@pei711

@pei711 pei711 commented Oct 24, 2026

Copy link
Copy Markdown

What: replaced/removed 3 dead external reference links in resilience-pattern READMEs (Spring guide 404, Resilience4j docs 404, microservices.io 404).
Why: the old URLs return HTTP 404; replacements verified HTTP 200 and cover the same topics.
How verified: curl HEAD/GET on old (404) and new (200) URLs; git diff reviewed; no other lines touched.
No linked issue; same-repo precedent: #3409, #3394, #1525 (merged broken-link fixes).

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

PR Summary

Replaced three dead external references in resilience READMEs with active equivalents (HTTP 200 OK). Updated links to current, maintained sources: circuit-breaker/README.md now points to Spring Cloud Circuit Breaker docs at https://docs.spring.io/spring-cloud-circuitbreaker/reference/; fallback/README.md uses https://resilience4j.readme.io/docs/getting-started-3; microservices-load-shedding/README.md removed the broken Microservices.io Load Shedding reference. Verification included curl HEAD/GET checks on old (404) URLs and confirmation of updated links; no other changes touched.

Changes

File Summary
circuit-breaker/README.md Replaced dead external link for the Circuit Breaker section with the official Spring Cloud Circuit Breaker reference, pointing to https://docs.spring.io/spring-cloud-circuitbreaker/reference/.
fallback/README.md Updated Resilience4j Fallback link from the old docs page to the current Getting Started page: https://resilience4j.readme.io/docs/getting-started-3.
microservices-load-shedding/README.md Removed the broken Load Shedding reference to microservices.io from References and Credits.

autogenerated by presubmit.ai

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

Review Summary

Commits Considered (1)
  • 87d48fa: docs: fix broken reference links in resilience READMEs
Files Processed (3)
  • circuit-breaker/README.md (1 hunk)
  • fallback/README.md (1 hunk)
  • microservices-load-shedding/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
  • circuit-breaker/README.md [196-196]

    best_practice: "Replace broken external reference with official docs"

  • fallback/README.md [94-94]

    maintainability: "Add resilience4j Fallback doc reference"

@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.07%. Comparing base (4cabb20) to head (87d48fa).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3629   +/-   ##
=========================================
  Coverage     84.06%   84.07%           
- Complexity     4353     4354    +1     
=========================================
  Files          1133     1133           
  Lines         15400    15400           
  Branches        739      739           
=========================================
+ Hits          12946    12947    +1     
  Misses         2158     2158           
+ Partials        296      295    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant