chore(api): Introduce separation of EventFilter / AggregationFilter on API-level - #3931
Open
awildturtok wants to merge 4 commits into
Open
chore(api): Introduce separation of EventFilter / AggregationFilter on API-level#3931awildturtok wants to merge 4 commits into
awildturtok wants to merge 4 commits into
Conversation
awildturtok
marked this pull request as ready for review
August 4, 2026 12:53
awildturtok
changed the title
awildturtok
force-pushed
the
feature/ai/seperate-event-filter-and-aggregation-filters
branch
from
August 5, 2026 15:05
3c1ea93 to
8ea0439
Compare
awildturtok
force-pushed
the
feature/ai/seperate-event-filter-and-aggregation-filters
branch
from
August 5, 2026 15:08
8ea0439 to
114b675
Compare
thoniTUB
requested changes
Aug 6, 2026
| public QPNode createQueryPlan(QueryPlanContext context, ConceptQueryPlan plan) { | ||
|
|
||
| final List<Aggregator<?>> conceptAggregators = createAggregators(plan, selects, context); | ||
| final List<Aggregator<?>> conceptAggregators = createAggregators(plan, selects, context.isDisableAggregators()); |
Collaborator
There was a problem hiding this comment.
Bubble up
Suggested change
| final List<Aggregator<?>> conceptAggregators = createAggregators(plan, selects, context.isDisableAggregators()); | |
| final List<Aggregator<?>> conceptAggregators = context.isDisableAggregators() ? Collections.emptyList() : createAggregators(plan, selects); |
| @SuppressWarnings({"unchecked", "rawtypes"}) | ||
| @Override | ||
| public FilterNode createFilterNode(Range.LongRange value) { | ||
| public AggregationResultFilterNode<?, ?> createFilterNode(Range.LongRange value) { |
Collaborator
There was a problem hiding this comment.
Ich würde Result droppen, da du die andere Klasse AggregationFilter genannt hast anstatt AggregationResultFilter
Suggested change
| public AggregationResultFilterNode<?, ?> createFilterNode(Range.LongRange value) { | |
| public AggregationFilterNode<?, ?> createFilterNode(Range.LongRange value) { |
Comment on lines
+70
to
+80
| @JsonIgnore | ||
| @ValidationMethod(message = "Columns do not match required Type.") | ||
| public boolean isValidColumnType() { | ||
|
|
||
| if (column != null) { | ||
| return ColumnUtils.assertValidColumnTypes(this, column, Set.of(MajorTypeId.DATE, DATE_RANGE)); | ||
| } | ||
|
|
||
| return ColumnUtils.assertValidColumnTypes(this, startColumn, Set.of(MajorTypeId.DATE)) && | ||
| ColumnUtils.assertValidColumnTypes(this, endColumn, Set.of(MajorTypeId.DATE)); | ||
| } |
Collaborator
There was a problem hiding this comment.
Gleich bitte mal mit den Validierungen in DaterangeSelectOrFilter ab die hier auch applied werden sollten. Sieht für mich doppelt aus
Comment on lines
101
to
103
| @JsonIgnore | ||
| @ValidationMethod(message = "Columns do not match required Type.") | ||
| public boolean isValidColumnType() { |
Collaborator
There was a problem hiding this comment.
Kann wahrscheinlich auch gelöscht werden da es schon durch DaterangeSelectOrFilter abgedeckt ist
| @Slf4j | ||
| @EqualsAndHashCode(callSuper = true) | ||
| public abstract class Filter<FILTER_VALUE> extends LabeledNamespaceIdentifiable<FilterId> { | ||
| public abstract sealed class Filter<FILTER_VALUE> extends LabeledNamespaceIdentifiable<FilterId> |
Collaborator
Author
There was a problem hiding this comment.
Das schöne ist sogar, dass ich das genau so machen wollte. Und Codex das von selbst so angewandt hat 🔥
Collaborator
There was a problem hiding this comment.
hattest du für codex ein coauthored gesetzt?
awildturtok
enabled auto-merge (squash)
August 6, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seperates EventFilter / AggregaionFilter on the API-class level
Co-Authored-By: CODEX