Repository navigation
Conversation
When inletsctl create finishes on Azure, print --subscription-id in the sample delete command so users can tear down the exit node without hitting InvalidSubscriptionId. Signed-off-by: hippi345 <13539685+hippi345@users.noreply.github.com>
|
Thank you for your contribution. It seems that one or more of your commits have a "Signed-off-by" statement with an anonymous email address. The Developer Certificate of Origin (DCO) requires all commits to be signed off by genuine, contactable individuals. Please see our contributing guide. This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
Description
After
inletsctl createon Azure, the printedinletsctl deleteexample left out--subscription-id, so copy-pasting it failed withInvalidSubscriptionIdunless the flag was added by hand. The sample now includes--subscription-idwhen it's set with the flag or present in the Azure credentials JSON (subscriptionId). Both the HTTPS and TCP summaries use the new helper.Closes #117
How Has This Been Tested?
make gofmtmake testmake allAdded unit tests for
subscriptionIDFromAzureAuthandsampleDeleteCommand.How are existing users impacted? What migration steps/scripts do we need?
No breaking changes. Other providers see the same delete line as before. Azure users get a complete delete command when a subscription ID is available.
Checklist:
I have:
git commit -s