Skip to content

Include Azure subscription-id in create delete sample - #142

Open
hippi345 wants to merge 1 commit into
inlets:masterfrom
hippi345:cursor/add-azure-subscription-delete-cmd-5232
Open

hippi345 wants to merge 1 commit into
inlets:masterfrom
hippi345:cursor/add-azure-subscription-delete-cmd-5232

Conversation

@hippi345

Copy link
Copy Markdown

Description

After inletsctl create on Azure, the printed inletsctl delete example left out --subscription-id, so copy-pasting it failed with InvalidSubscriptionId unless the flag was added by hand. The sample now includes --subscription-id when it's set with the flag or present in the Azure credentials JSON (subscriptionId). Both the HTTPS and TCP summaries use the new helper.

Closes #117

How Has This Been Tested?

  • make gofmt
  • make test
  • make all

Added unit tests for subscriptionIDFromAzureAuth and sampleDeleteCommand.

How are existing users impacted? What migration steps/scripts do we need?

No breaking changes. Other providers see the same delete line as before. Azure users get a complete delete command when a subscription ID is available.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

When inletsctl create finishes on Azure, print --subscription-id in the
sample delete command so users can tear down the exit node without hitting
InvalidSubscriptionId.

Signed-off-by: hippi345 <13539685+hippi345@users.noreply.github.com>
@derek

derek Bot commented Oct 30, 2026

Copy link
Copy Markdown

Thank you for your contribution. It seems that one or more of your commits have a "Signed-off-by" statement with an anonymous email address. The Developer Certificate of Origin (DCO) requires all commits to be signed off by genuine, contactable individuals. Please see our contributing guide.

### :bulb: Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the Azure subscription-id to the sample delete command given by inletsctl create

1 participant