Skip to content

Replace insightsengineering by pharmaverse - #297

Open
llrs-roche wants to merge 3 commits into
mainfrom
292_pharmaverse
Open

llrs-roche wants to merge 3 commits into
mainfrom
292_pharmaverse

Conversation

@llrs-roche

Copy link
Copy Markdown
Contributor

Pull Request

Fixes #292

I keep mentions to insightsengineering on configuration files that need it

@llrs-roche llrs-roche added the core label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      13       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  63       1  98.41%   40
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_outputs.R                 6       0  100.00%
R/qenv-get_var.R                    13       1  92.31%   13
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        1       1  0.00%    13
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                       29      29  0.00%    19-50
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      258       3  98.84%   160, 258, 326
R/utils.R                           42       0  100.00%
TOTAL                              569      41  92.79%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 9a5accc

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   14 suites   6s ⏱️
189 tests 185 ✅ 4 💤 0 ❌
273 runs  269 ✅ 4 💤 0 ❌

Results for commit 9a5accc.

♻️ This comment has been updated with latest results.

@osenan osenan self-assigned this Sep 14, 2026

@osenan osenan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there are some more lines that should be changed.
In addition look at files:

*inst/_pkgdown.yml

  • many files within the github workflow:
    • check.yml
    • cla.yml
    • release.yml
    • post-release.yml
    • scheduled.yml
  • then for the issue template:
    • cran-release.yml
    • release.yml

In other PRs many of these files have been modified, they still have references to insights engineering

Comment thread .github/CONTRIBUTING.md

## Recognition model

As mentioned previously, all contributions are deeply valued and appreciated. While all contribution data is available as part of the [repository insights][insights], to recognize a _significant_ contribution and hence add the contributor to the package authors list, the following rules are enforced:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not we change here a reference to pharmaverse?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss later with everybody

Comment thread DESCRIPTION
@llrs-roche

Copy link
Copy Markdown
Contributor Author

I think that there are some more lines that should be changed. In addition look at files:

  • inst/_pkgdown.yml

I think this is a leftover from some internal build that can be removed because the one used by pkgdown is on the top level directory of the package/repo.

  • many files within the github workflow:

    • check.yml
    • cla.yml
    • release.yml
    • post-release.yml
    • scheduled.yml
  • then for the issue template:

    • cran-release.yml
    • release.yml

In other PRs many of these files have been modified, they still have references to insights engineering

In other PR I have modified and reverted it back. Many if not all don't need changes as the CI tooling is still on insightsengineering and that won't change for now

@osenan osenan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for answering my comments. I consider the answers good to approve the PR, only the reference to contributing is pending and it can be discussed without blocking the approval.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to Pharmaverse

3 participants