Replace insightsengineering by pharmaverse - #297
llrs-roche wants to merge 3 commits into
Conversation
Code Coverage SummaryDiff against mainResults for commit: 9a5accc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 14 suites 6s ⏱️ Results for commit 9a5accc. ♻️ This comment has been updated with latest results. |
osenan
left a comment
There was a problem hiding this comment.
I think that there are some more lines that should be changed.
In addition look at files:
*inst/_pkgdown.yml
- many files within the github workflow:
- check.yml
- cla.yml
- release.yml
- post-release.yml
- scheduled.yml
- then for the issue template:
- cran-release.yml
- release.yml
In other PRs many of these files have been modified, they still have references to insights engineering
|
|
||
| ## Recognition model | ||
|
|
||
| As mentioned previously, all contributions are deeply valued and appreciated. While all contribution data is available as part of the [repository insights][insights], to recognize a _significant_ contribution and hence add the contributor to the package authors list, the following rules are enforced: |
There was a problem hiding this comment.
should not we change here a reference to pharmaverse?
There was a problem hiding this comment.
Let's discuss later with everybody
I think this is a leftover from some internal build that can be removed because the one used by pkgdown is on the top level directory of the package/repo.
In other PR I have modified and reverted it back. Many if not all don't need changes as the CI tooling is still on insightsengineering and that won't change for now |
osenan
left a comment
There was a problem hiding this comment.
Thank you for answering my comments. I consider the answers good to approve the PR, only the reference to contributing is pending and it can be discussed without blocking the approval.
Pull Request
Fixes #292
I keep mentions to insightsengineering on configuration files that need it