Skip to content

chore: Allow to change cwd of transcoder#51

Open
elthariel wants to merge 1 commit into
instructure:mainfrom
elthariel:lta/spawn_opts
Open

chore: Allow to change cwd of transcoder#51
elthariel wants to merge 1 commit into
instructure:mainfrom
elthariel:lta/spawn_opts

Conversation

@elthariel

Copy link
Copy Markdown
Contributor

While using two pass encoders, it can be helpful to change the current working directory of the ffmpeg binaries.

This PR does just that by allowing to provide extra args to Open3 module functions.

PS: 3 tests are failing on my box, both on my branch and the up-to-date main branch, so I didn't take the time to investigate yet

to help managing the two pass encoding logfiles
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@elthariel

elthariel commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Ok, there's a CLA now. Not sure I can sign it, I need to ask my company.

edit: I'm not sure I get why the CLA is required since the code is MIT ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants