Repository navigation
[C API] Use the builder logger for stream loads - #444
Merged
Merged
Conversation
Pass the index builder's logger to the Vamana and DynamicVamana stream assemble overloads instead of falling back to the global default logger.
yuejiaointel
requested review from
ahuber21,
ethanglaser and
rfsaliev
as code owners
October 22, 2026 05:20
ahuber21
requested changes
Oct 22, 2026
ahuber21
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
svs_index_load_streamandsvs_index_load_stream_dynamicnow honor the logger set withsvs_index_builder_set_logger.Why: indexes restored from a stream (e.g. a Valkey RDB load) lost their per-index logger and logged through the global default logger instead.
How: the stream-load dispatchers pass the builder's logger (
get_logger()) to theVamana::assemble(std::istream&, ...)andDynamicVamana::assemble(std::istream&, ...)overloads, which already accept one; thesvs_c.hremark saying stream loads ignore the builder logger is removed.Testing: existing C API unit tests pass, public-only and LVQ/LeanVec + LTO builds (23/23 each).
🤖 Generated with Claude Code