Repository navigation
Keep debug_load_from_static last in DynamicVamana::assemble - #445
Open
yuejiaointel wants to merge 2 commits into
Open
yuejiaointel wants to merge 2 commits into
yuejiaointel wants to merge 2 commits into
Conversation
yuejiaointel
marked this pull request as ready for review
October 22, 2026 18:41
yuejiaointel
requested review from
ethanglaser,
mihaic and
rfsaliev
as code owners
October 22, 2026 18:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#407 added the
loggerargument afterdebug_load_from_static, and #417 copied that order to the stream overload. Callers that only want a logger then had to pass the internal debug flag too. This movesloggerbeforedebug_load_from_staticin bothDynamicVamana::assembleoverloads, and in bothConcurrentDynamicVamana::assembleoverloads (added in #418 with the same order; not yet released). The coreauto_dynamic_assembleorder is unchanged.Callers that pass both arguments in the old order now get a compile error; nothing changes silently. The Python binding, the only caller that passes the debug flag, now passes
svs::logging::get()before it.Tests:
[managers][dynamic_vamana]and[logging]pass, and[managers][concurrent_dynamic_vamana],[concurrent]pass, and the C API unit tests pass (26/26). Python was not built locally.🤖 Generated with Claude Code