Skip to content

Keep debug_load_from_static last in DynamicVamana::assemble - #445

Open
yuejiaointel wants to merge 2 commits into
mainfrom
yuejiao/dynamic-assemble-arg-order
Open

yuejiaointel wants to merge 2 commits into
mainfrom
yuejiao/dynamic-assemble-arg-order

Conversation

@yuejiaointel

@yuejiaointel yuejiaointel commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

#407 added the logger argument after debug_load_from_static, and #417 copied that order to the stream overload. Callers that only want a logger then had to pass the internal debug flag too. This moves logger before debug_load_from_static in both DynamicVamana::assemble overloads, and in both ConcurrentDynamicVamana::assemble overloads (added in #418 with the same order; not yet released). The core auto_dynamic_assemble order is unchanged.

Callers that pass both arguments in the old order now get a compile error; nothing changes silently. The Python binding, the only caller that passes the debug flag, now passes svs::logging::get() before it.

Tests: [managers][dynamic_vamana] and [logging] pass, and [managers][concurrent_dynamic_vamana], [concurrent] pass, and the C API unit tests pass (26/26). Python was not built locally.

🤖 Generated with Claude Code

#407 added the logger argument after debug_load_from_static, and #417
copied that order to the stream overload, so callers that only want a
logger had to pass the internal debug flag too. Move logger before
debug_load_from_static in both overloads. The core auto_dynamic_assemble
order is unchanged.
@yuejiaointel
yuejiaointel requested a review from ahuber21 October 22, 2026 16:05
@yuejiaointel
yuejiaointel marked this pull request as ready for review October 22, 2026 18:41

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant