Repository navigation
Conversation
…al-to-external mapping - Added methods to estimate memory usage and manage internal capacity. - Updated memory management in MutableVamanaIndex and DynamicFlatIndex to utilize new translator methods. - Improved error handling for invalid external IDs and ensured proper resizing of internal structures.
razdoburdin
reviewed
Oct 23, 2026
razdoburdin
left a comment
razdoburdin
left a comment
Member
There was a problem hiding this comment.
Great idea!
It can be even more important for concurrent index. If grow stable storage is used for internal_to_external, it could allow to drop some locks, but it requires additional research.
| // using bucket_type = tsl::detail_robin_hash:: | ||
| // bucket_entry<std::pair<external_id_type, internal_id_type>, false>; | ||
| // external_to_internal_.bucket_count() * sizeof(bucket_type) | ||
| return size() * (sizeof(external_id_type) + sizeof(internal_id_type)) + |
Member
There was a problem hiding this comment.
What's wrong with bucket_count() * sizeof(bucket_type) estimation? It should be ok for trivial types.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the draft pull request to demonstrate ability to use simple vector for internal-to-external ID translation.
Benefits:
invalid_external_id).