Repository navigation
libcamhal: Fix V4L2 stride calculation and handle EBUSY during format setting - #84
Open
123456987789 wants to merge 2 commits into
Open
123456987789 wants to merge 2 commits into
123456987789 wants to merge 2 commits into
Conversation
Signed-off-by: Pengpeng He <pengpengx.he@intel.com>
Independent preview processes may request the same V4L2 format. After one process sets it, another may receive EBUSY on the same request. This does not prevent preview from continuing. Treat EBUSY from video-node and subdevice format-setting ioctls as non-fatal, log it at warning level, and return success. Preserve the original ioctl error for all other failures. Signed-off-by: Pengpeng He <pengpengx.he@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Ensure format-aware stride calculation and avoid aborting preview on EBUSY during format configuration.