Repository navigation
[SYCL] add local config to reenable atomic tests - #23583
Merged
dm-vodopyanov merged 7 commits intoOct 22, 2026
Merged
Conversation
uditagarwal97
approved these changes
Oct 21, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Device-dependent build flags omit extended coverage in split build/run workflows and enable unsupported cases in mixed-device runs.
2 open issues
What changed in this PR
Restores non-CRI AtomicRef test coverage disabled by #23559 and centralizes CRI-specific build flags.
Changes:
- Adds
%{build_atomic}with conditional full-coverage flags. - Replaces duplicate build/run commands across atomic tests.
- Removes CRI-only requirements from operation and Level Zero aspect tests.
| File | Description |
|---|---|
| sycl/test-e2e/AtomicRef/xor.cpp | Re-enables baseline XOR coverage. |
| sycl/test-e2e/AtomicRef/xor_local.cpp | Re-enables local XOR coverage. |
| sycl/test-e2e/AtomicRef/xor_generic.cpp | Re-enables generic XOR coverage. |
| sycl/test-e2e/AtomicRef/xor_generic_local.cpp | Re-enables generic-local XOR coverage. |
| sycl/test-e2e/AtomicRef/sub.cpp | Re-enables baseline subtraction coverage. |
| sycl/test-e2e/AtomicRef/sub_local.cpp | Re-enables local subtraction coverage. |
| sycl/test-e2e/AtomicRef/sub_generic.cpp | Re-enables generic subtraction coverage. |
| sycl/test-e2e/AtomicRef/sub_generic_local.cpp | Re-enables generic-local subtraction coverage. |
| sycl/test-e2e/AtomicRef/store.cpp | Re-enables baseline store coverage. |
| sycl/test-e2e/AtomicRef/store_local.cpp | Re-enables local store coverage. |
| sycl/test-e2e/AtomicRef/store_generic.cpp | Re-enables generic store coverage. |
| sycl/test-e2e/AtomicRef/store_generic_local.cpp | Re-enables generic-local store coverage. |
| sycl/test-e2e/AtomicRef/or.cpp | Re-enables baseline OR coverage. |
| sycl/test-e2e/AtomicRef/or_local.cpp | Re-enables local OR coverage. |
| sycl/test-e2e/AtomicRef/or_generic.cpp | Re-enables generic OR coverage. |
| sycl/test-e2e/AtomicRef/or_generic_local.cpp | Re-enables generic-local OR coverage. |
| sycl/test-e2e/AtomicRef/min.cpp | Re-enables baseline minimum coverage. |
| sycl/test-e2e/AtomicRef/min_local.cpp | Re-enables local minimum coverage. |
| sycl/test-e2e/AtomicRef/min_generic.cpp | Re-enables generic minimum coverage. |
| sycl/test-e2e/AtomicRef/min_generic_local.cpp | Re-enables generic-local minimum coverage. |
| sycl/test-e2e/AtomicRef/max.cpp | Re-enables baseline maximum coverage. |
| sycl/test-e2e/AtomicRef/max_local.cpp | Re-enables local maximum coverage. |
| sycl/test-e2e/AtomicRef/max_generic.cpp | Re-enables generic maximum coverage. |
| sycl/test-e2e/AtomicRef/max_generic_local.cpp | Re-enables generic-local maximum coverage. |
| sycl/test-e2e/AtomicRef/load.cpp | Re-enables baseline load coverage. |
| sycl/test-e2e/AtomicRef/load_local.cpp | Re-enables local load coverage. |
| sycl/test-e2e/AtomicRef/load_generic.cpp | Re-enables generic load coverage. |
| sycl/test-e2e/AtomicRef/load_generic_local.cpp | Re-enables generic-local load coverage. |
| sycl/test-e2e/AtomicRef/lit.local.cfg | Defines device-dependent atomic build flags. |
| sycl/test-e2e/AtomicRef/exchange.cpp | Re-enables baseline exchange coverage. |
| sycl/test-e2e/AtomicRef/exchange_local.cpp | Re-enables local exchange coverage. |
| sycl/test-e2e/AtomicRef/exchange_generic.cpp | Re-enables generic exchange coverage. |
| sycl/test-e2e/AtomicRef/exchange_generic_local.cpp | Re-enables generic-local exchange coverage. |
| sycl/test-e2e/AtomicRef/device_has_aspect_atomic16_level_zero.cpp | Broadens aspect testing beyond CRI. |
| sycl/test-e2e/AtomicRef/compare_exchange.cpp | Re-enables baseline compare-exchange coverage. |
| sycl/test-e2e/AtomicRef/compare_exchange_local.cpp | Re-enables local compare-exchange coverage. |
| sycl/test-e2e/AtomicRef/compare_exchange_generic.cpp | Re-enables generic compare-exchange coverage. |
| sycl/test-e2e/AtomicRef/compare_exchange_generic_local.cpp | Re-enables generic-local compare-exchange coverage. |
| sycl/test-e2e/AtomicRef/atomic_ref.cpp | Uses shared build flags; retains CRI requirement. |
| sycl/test-e2e/AtomicRef/and.cpp | Re-enables baseline AND coverage. |
| sycl/test-e2e/AtomicRef/and_local.cpp | Re-enables local AND coverage. |
| sycl/test-e2e/AtomicRef/and_generic.cpp | Re-enables generic AND coverage. |
| sycl/test-e2e/AtomicRef/and_generic_local.cpp | Re-enables generic-local AND coverage. |
| sycl/test-e2e/AtomicRef/add.cpp | Re-enables baseline addition coverage. |
| sycl/test-e2e/AtomicRef/add_local.cpp | Re-enables local addition coverage. |
| sycl/test-e2e/AtomicRef/add_generic.cpp | Re-enables generic addition coverage. |
| sycl/test-e2e/AtomicRef/add_generic_local.cpp | Re-enables generic-local addition coverage. |
Review effort: Balanced
Contributor
Author
|
The failures are not related to PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR disabled default atomic tests for non-cri targets. This PR restores it by adding local lit config file. If CRI GPU target is detected, it additional macro to enable full coverage of atomic support.