Repository navigation
[SYCL] Restrict event signal for pending command and dependencies. - #23591
Open
slawekptak wants to merge 1 commit into
Open
slawekptak wants to merge 1 commit into
slawekptak wants to merge 1 commit into
Conversation
If a submitted command is pending in the runtime, or any of its dependencies is pending, check and throw an exception when the event produced by that command is passed to enqueue_signal_event. Enqueueing an event for signaling is not allowed when that event is pending or has pending dependnecies, since the event will be reused and would drop the current dependencies and current signal and this can only be done, if all of those operations are submitted to the backend. Assisted-by: Claude
gmlueck
reviewed
Oct 23, 2026
Contributor
There was a problem hiding this comment.
The paragraph at the top of this section already says this:
but a violation is only diagnosed in some cases. The implementation throws an
exceptionwith theerrc::invaliderror code if, at the point of the call, the command which the "event signal" or
"event wait" operation depends on is still pending inside the SYCL runtime. If that command has already been submitted to the backend by then, the operation succeeds instead.
Is this bullet item just saying the same thing?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a submitted command is pending in the runtime, or any of its dependencies is pending, check and throw an exception when the event produced by that command is passed to enqueue_signal_event.
Enqueueing an event for signaling is not allowed when that event is pending or has pending dependnecies, since the event will be reused and would drop the current dependencies and current signal and this can only be done, if all of those operations are submitted to the backend.
Assisted-by: Claude