Repository navigation
[PB-6989]: chore/remove legacy status flags - #714
Merged
Merged
Conversation
jzunigax2
changed the title
jzunigax2
changed the base branch from
main
to
chore/remove-legacy-item-fields
October 23, 2026 22:39
jzunigax2
force-pushed
the
chore/remove-legacy-status-flags
branch
from
October 26, 2026 10:11
d403103 to
8a29c0c
Compare
jzunigax2
force-pushed
the
chore/remove-legacy-status-flags
branch
from
October 26, 2026 10:16
8a29c0c to
dce8077
Compare
jzunigax2
marked this pull request as ready for review
October 26, 2026 10:18
larryrider
approved these changes
Oct 26, 2026
jzunigax2
force-pushed
the
chore/remove-legacy-status-flags
branch
from
October 26, 2026 13:26
dce8077 to
d8ff916
Compare
…prove folder metadata handling
jzunigax2
force-pushed
the
chore/remove-legacy-status-flags
branch
from
October 27, 2026 09:49
d8ff916 to
6d2d7d9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boolean flags
deletedandremovedon folders are about to be deprecated.statusreplaces them. After this PR the CLI no longer reads either flag anywhere. Every folder it reads takes its status from the API response.Changes
DriveUtils.driveFolderMetaToItemnow readsstatusfrom the response. Before, it worked the status out from the flags, and it used the trashed status for removed folders too, which was wrong.DriveFolderService.findExistentFolderreusesdriveFolderMetaToItem. It no longer hard-codesEXISTSor relies on the backend filtering out trashed and removed folders.PROPFINDtakes child folder status straight fromfolder.status.createFolderResponseToItemsetsEXISTS. The SDK's create response type has nostatusfield, and a folder that was just created always exists. The old flag-based logic also always gaveEXISTShere.