Repository navigation
[_]: chore/appy-prettier-format - #165
Merged
larryrider merged 15 commits intoOct 28, 2026
Merged
Conversation
…nd package-lock.json
…ipt-eslint dependency
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
object-storage-management-web | 3e7e4f1 | Commit Preview URL Branch Preview URL |
Oct 28 2026, 08:34 AM |
jzunigax2
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the previous CI/husky/prettier PR: applies the formatting pass that was deferred to keep that PR reviewable, turns on
eslintin CI and pre-commit now that the repo is formatted, and fixes everything that surfaced.eslintas a blocking step in both the GitHub Action and thepre-commithook.const fetchX = ...declarations that were referenced by auseEffectabove them (temporal-dead-zone bug, not just style).react-hooks/refs: moved a DOM measurement (Dropdown) touseLayoutEffect, converted a "sticky" ref read during render (SubAccountBucketDetailPage) touseState.react-hooks/incompatible-library: replaced react-hook-form'swatch()withuseWatch()in 6 forms (the React Compiler-compatible API for the same thing).@typescript-eslint/no-explicit-any: replacedanywith real types in 3 files.no-console: removed leftover debug logging (including one that was logging S3accessKeyId/secretAccessKeyto the browser console), wired two swallowed errors up to the existing toast notification pattern instead, kept twoDEV-gated non-sensitive diagnostics.react-hooks/exhaustive-deps: wrapped shared fetch functions inuseCallbackwith their real dependencies, stabilized a couple of previously-unstableonClosecallback props and aserviceprop that was a new object every render, and addednavigate/getSetup/etc. where they were safely stable. A handful of cases are narrowed on purpose (shared fetch function reused by a debounced search effect, a memoized S3 client), those are annotated inline rather than "fixed" in a way that would've added extra, unwanted requests.react-hooks/set-state-in-effect: kept aterror. The ~57 existing call sites got a bareeslint-disable-next-lineinstead of a rewrite, there is no documented fix for the dominant patterns here (fetch-on-mount, reset state on prop change), confirmed against React's own docs and a tracked upstream issuefacebook/react#34743.react-refresh/only-export-components: split the 5 context files (Provider + hook in one module) and 2 utility modules into dedicated files, so each file exports only one kind of thing; rule is back toerror.eslint.config.js->eslint.config.mjsto match theclirepo's structure; bumped@internxt/eslint-config-internxtto2.1.2(dropped ourmax-lenoverride, now redundant with the package's default); removed the now-unusedtypescript-eslintdependency.@internxt/css-configtodevDependencies(it's only used bytailwind.config.js); removed 10 packages with zero references anywhere in the codebase, confirmed withknipand manual verification (@stripe/react-stripe-js,@stripe/stripe-js,@tailwindcss/vite,class-variance-authority,history,tw-animate-css,use-debounce,zod,@tailwindcss/postcss,@types/react-router-dom).